starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-02-04 05:44:53 +00:00
Code Issues 1.5k Packages Projects Releases 20 Wiki Activity

[PR #1738] [MERGED] [FEAT] Removed C code already ported to Rust #2461

New Issue
Closed
opened 2026-01-29 17:22:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:22:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1738
Author: @steel-bucket
Created: 8/24/2025
Status: ✅ Merged
Merged: 9/6/2025
Merged by: @prateekmedia

Base: master ← Head: removal-c-code

📝 Commits (9)

  • 5ae7068 Removal: Removed redundant C code already ported to Rust
  • 2a96888 Removal: C formatting
  • 493bab5 Removal: More Removal and CI issues in Mac
  • 1129906 Removal: CI issues in Mac
  • cb00751 Merge branch 'master' into removal-c-code
  • e714356 Removal: Changes due to Rebase
  • e2b4fbf Removal: Failing CI on mac
  • 10f8aa6 Removal: Failing regression test on dvdraw
  • 2568f54 Merge branch 'CCExtractor:master' into removal-c-code

📊 Changes

28 files changed (+199 additions, -4217 deletions)

View changed files

📝 docs/COMPILATION.MD (+0 -2)
📝 docs/using_cmake_build.txt (+0 -3)
📝 linux/Makefile.am (+0 -5)
📝 linux/build (+20 -29)
📝 mac/Makefile.am (+1 -5)
📝 mac/build.command (+172 -47)
📝 src/CMakeLists.txt (+2 -5)
📝 src/ccextractor.c (+0 -6)
📝 src/lib_ccx/CMakeLists.txt (+0 -4)
📝 src/lib_ccx/cc_bitstream.c (+0 -281)
📝 src/lib_ccx/ccx_common_common.c (+0 -10)
📝 src/lib_ccx/ccx_common_common.h (+0 -2)
📝 src/lib_ccx/ccx_common_timing.c (+0 -278)
📝 src/lib_ccx/ccx_decoders_708.c (+0 -21)
📝 src/lib_ccx/ccx_decoders_708_encoding.c (+0 -36)
📝 src/lib_ccx/ccx_decoders_708_encoding.h (+0 -7)
📝 src/lib_ccx/ccx_decoders_708_output.c (+2 -4)
📝 src/lib_ccx/ccx_decoders_common.c (+1 -20)
📝 src/lib_ccx/ccx_encoders_common.c (+0 -219)
📝 src/lib_ccx/ccx_encoders_common.h (+0 -2)

...and 8 more files

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR removes the C code which were ported to Rust already, as discussed in zulip.
This PR also re-makes the entire Mac build.command, as before this, we were always compiling on Mac with DISABLE_RUST on.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1738 **Author:** [@steel-bucket](https://github.com/steel-bucket) **Created:** 8/24/2025 **Status:** ✅ Merged **Merged:** 9/6/2025 **Merged by:** [@prateekmedia](https://github.com/prateekmedia) **Base:** `master` ← **Head:** `removal-c-code` --- ### 📝 Commits (9) - [`5ae7068`](https://github.com/CCExtractor/ccextractor/commit/5ae7068cc3f68d84005354ebfbb960fe18dade7e) Removal: Removed redundant C code already ported to Rust - [`2a96888`](https://github.com/CCExtractor/ccextractor/commit/2a968885b6dec2b345c0b3313d2e70eb077f9685) Removal: C formatting - [`493bab5`](https://github.com/CCExtractor/ccextractor/commit/493bab5c0e2b2d6e15ab8bfda18986b39c278942) Removal: More Removal and CI issues in Mac - [`1129906`](https://github.com/CCExtractor/ccextractor/commit/1129906cc316d24791eaed9da7d304c6ff09251d) Removal: CI issues in Mac - [`cb00751`](https://github.com/CCExtractor/ccextractor/commit/cb00751ca3215a8697e125dde5171a4e4f2f9764) Merge branch 'master' into removal-c-code - [`e714356`](https://github.com/CCExtractor/ccextractor/commit/e714356da31fce91b8a6afc66946d12ff07b6535) Removal: Changes due to Rebase - [`e2b4fbf`](https://github.com/CCExtractor/ccextractor/commit/e2b4fbffb1d938e09834ddb54d3552439caa0933) Removal: Failing CI on mac - [`10f8aa6`](https://github.com/CCExtractor/ccextractor/commit/10f8aa65b33f028f170abf79a4b568f84c38afd1) Removal: Failing regression test on dvdraw - [`2568f54`](https://github.com/CCExtractor/ccextractor/commit/2568f545b2a43684bdcb14e96dac6047ae97cd50) Merge branch 'CCExtractor:master' into removal-c-code ### 📊 Changes **28 files changed** (+199 additions, -4217 deletions) <details> <summary>View changed files</summary> 📝 `docs/COMPILATION.MD` (+0 -2) 📝 `docs/using_cmake_build.txt` (+0 -3) 📝 `linux/Makefile.am` (+0 -5) 📝 `linux/build` (+20 -29) 📝 `mac/Makefile.am` (+1 -5) 📝 `mac/build.command` (+172 -47) 📝 `src/CMakeLists.txt` (+2 -5) 📝 `src/ccextractor.c` (+0 -6) 📝 `src/lib_ccx/CMakeLists.txt` (+0 -4) 📝 `src/lib_ccx/cc_bitstream.c` (+0 -281) 📝 `src/lib_ccx/ccx_common_common.c` (+0 -10) 📝 `src/lib_ccx/ccx_common_common.h` (+0 -2) 📝 `src/lib_ccx/ccx_common_timing.c` (+0 -278) 📝 `src/lib_ccx/ccx_decoders_708.c` (+0 -21) 📝 `src/lib_ccx/ccx_decoders_708_encoding.c` (+0 -36) 📝 `src/lib_ccx/ccx_decoders_708_encoding.h` (+0 -7) 📝 `src/lib_ccx/ccx_decoders_708_output.c` (+2 -4) 📝 `src/lib_ccx/ccx_decoders_common.c` (+1 -20) 📝 `src/lib_ccx/ccx_encoders_common.c` (+0 -219) 📝 `src/lib_ccx/ccx_encoders_common.h` (+0 -2) _...and 8 more files_ </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This PR removes the C code which were ported to Rust already, as discussed in zulip. This PR also re-makes the entire Mac `build.command`, as before this, we were always compiling on Mac with DISABLE_RUST on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:22:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2461
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?