[PR #895] [MERGED] [FIX] Fix Travis CI not executing linux/build #1738

New Issue

claunia · 2026-01-29T17:18:16Z

claunia commented

2026-01-29 17:18:16 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/895
Author: @harrynull
Created: 1/11/2018
Status: ✅ Merged
Merged: 1/11/2018
Merged by: @canihavesomecoffee

Base: master ← Head: ci

📝 Commits (4)

19352fd debug travis
9c1e7c5 Fix travis
98edef2 Add more cd
3203ac1 Change to before_install

📊 Changes

1 file changed (+5 additions, -6 deletions)

View changed files

📝 .travis.yml (+5 -6)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

During installing the dependencies, one of the command forgets to exit the directory:

if [[ $TRAVIS_OS_NAME == 'linux' ]]; then wget https://github.com/DanBloomberg/leptonica/releases/download/1.74.4/leptonica-1.74.4.tar.gz && tar xvf leptonica-1.74.4.tar.gz; cd leptonica-1.74.4; ./configure && make && sudo make install; fi

It makes cd linux; ./build; cd ..; fi fail to execute.

I also changed install to before_install, as suggested by travis:

In a before_install step, you can install additional dependencies required by your project such as Ubuntu packages or custom services.

It can make the verbose dependencies installation collapsed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/895 **Author:** [@harrynull](https://github.com/harrynull) **Created:** 1/11/2018 **Status:** ✅ Merged **Merged:** 1/11/2018 **Merged by:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Base:** `master` ← **Head:** `ci` --- ### 📝 Commits (4) - [`19352fd`](https://github.com/CCExtractor/ccextractor/commit/19352fdd0369f83fc9cedc4c852c16a1d543a0bf) debug travis - [`9c1e7c5`](https://github.com/CCExtractor/ccextractor/commit/9c1e7c5c985232be3ea4373b6bda0893a787273c) Fix travis - [`98edef2`](https://github.com/CCExtractor/ccextractor/commit/98edef22336ef1aeb552596c1ad30e2cf7b641bf) Add more cd - [`3203ac1`](https://github.com/CCExtractor/ccextractor/commit/3203ac14d30603676cd4c8d980980e7a61c25376) Change to before_install ### 📊 Changes **1 file changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+5 -6) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- During installing the dependencies, one of the command forgets to exit the directory: ``` if [[ $TRAVIS_OS_NAME == 'linux' ]]; then wget https://github.com/DanBloomberg/leptonica/releases/download/1.74.4/leptonica-1.74.4.tar.gz && tar xvf leptonica-1.74.4.tar.gz; cd leptonica-1.74.4; ./configure && make && sudo make install; fi ``` It makes `cd linux; ./build; cd ..; fi` fail to execute. I also changed `install` to `before_install`, as suggested by travis: > In a before_install step, you can install additional dependencies required by your project such as Ubuntu packages or custom services. It can make the verbose dependencies installation collapsed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:18:16 +00:00

claunia referenced this issue

2026-01-29 17:22:16 +00:00

[PR #1738] [MERGED] [FEAT] Removed C code already ported to Rust #2461

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1738

[PR #895] [MERGED] [FIX] Fix Travis CI not executing linux/build #1738

📋 Pull Request Information

📝 Commits (4)

📊 Changes

📄 Description

[PR #895] [MERGED] [FIX] Fix Travis CI not executing `linux/build` #1738