Potential memory safety issues in Rust FFI exports (NULL pointer handling) #895

New Issue

claunia · 2026-01-29T16:56:26Z

claunia commented

2026-01-29 16:56:26 +00:00

Originally created by @THE-Amrit-mahto-05 on GitHub (Jan 5, 2026).

Description

While going through the Rust FFI layer, I noticed a few places where raw pointers coming from C are used without NULL checks. This can lead to undefined behavior if these functions are ever called with invalid inputs.

I’m still learning Rust FFI, so please correct me if I’m wrong, but based on my understanding these look like genuine safety issues.

What I found

ccxr_verify_crc32

buf is used without a NULL check
len is not checked for negative values before creating a slice

ccxr_levenshtein_dist and ccxr_levenshtein_dist_char

Pointer arguments are assumed to be non-NULL

Functions in libccxr_exports/bitstream.rs

Multiple exported FFI functions dereference *mut bitstream without checking for NULL (via copy_bitstream_c_to_rust)

Originally created by @THE-Amrit-mahto-05 on GitHub (Jan 5, 2026). ### Description While going through the Rust FFI layer, I noticed a few places where raw pointers coming from C are used without NULL checks. This can lead to undefined behavior if these functions are ever called with invalid inputs. I’m still learning Rust FFI, so please correct me if I’m wrong, but based on my understanding these look like genuine safety issues. ### What I found ccxr_verify_crc32 - buf is used without a NULL check - len is not checked for negative values before creating a slice ccxr_levenshtein_dist and ccxr_levenshtein_dist_char - Pointer arguments are assumed to be non-NULL Functions in libccxr_exports/bitstream.rs - Multiple exported FFI functions dereference *mut bitstream without checking for NULL (via copy_bitstream_c_to_rust)

claunia closed this issue

2026-01-29 16:56:26 +00:00

claunia commented

2026-01-29 16:56:27 +00:00

@cfsmp3 commented on GitHub (Jan 5, 2026):

Closing, explanation in PR.

@cfsmp3 commented on GitHub (Jan 5, 2026): Closing, explanation in PR.

claunia referenced this issue

2026-01-29 17:18:16 +00:00

[PR #895] [MERGED] [FIX] Fix Travis CI not executing `linux/build` #1738

claunia referenced this issue

2026-01-29 17:18:16 +00:00