[PR #1783] [FIX] Handle double-hyphens in XML comments in spupng encoder #2513

New Issue

claunia · 2026-01-29T17:22:32Z

claunia commented

2026-01-29 17:22:32 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1783

State: closed
Merged: Yes

Summary

Fixed write_spucomment to handle double-hyphens (--) which are invalid inside XML comments
The fix removes one hyphen when encountering -- sequences to produce valid XML output
Rebased onto current master
Applied clang-format

Supersedes #1642

Test plan

Generate SPUPNG output with captions containing --
Verify the resulting XML is valid

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1783 **State:** closed **Merged:** Yes --- ## Summary - Fixed `write_spucomment` to handle double-hyphens (`--`) which are invalid inside XML comments - The fix removes one hyphen when encountering `--` sequences to produce valid XML output - Rebased onto current master - Applied clang-format Supersedes #1642 ## Test plan - Generate SPUPNG output with captions containing `--` - Verify the resulting XML is valid 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claunia added the pull-request label 2026-01-29 17:22:32 +00:00

claunia closed this issue

2026-01-29 17:22:32 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2513