[PR #963] [MERGED] [FIX] Fix possible segfaults in hardsubx_classifier.c due to strdup #1783

New Issue

claunia · 2026-01-29T17:18:32Z

claunia commented

2026-01-29 17:18:32 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/963
Author: @saurabhshah0410
Created: 3/12/2018
Status: ✅ Merged
Merged: 3/16/2018
Merged by: @cfsmp3

Base: master ← Head: 928

📝 Commits (1)

9c2dcc7 Fix possible segfaults in hardsubx_classifier.c due to strdup

📊 Changes

1 file changed (+20 additions, -8 deletions)

View changed files

📝 src/lib_ccx/hardsubx_classifier.c (+20 -8)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

strdup will give a segmentation fault if the argument passed to it is
NULL. TessResultIteratorGetUTF8Text returns a char* which can be NULL
and we should not call strdup directly over it. Once we check if the
value returned is not NULL, then we can call strdup.

This also fixes #928.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/963 **Author:** [@saurabhshah0410](https://github.com/saurabhshah0410) **Created:** 3/12/2018 **Status:** ✅ Merged **Merged:** 3/16/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `928` --- ### 📝 Commits (1) - [`9c2dcc7`](https://github.com/CCExtractor/ccextractor/commit/9c2dcc731cc8d091300f31943564403c30cf214a) Fix possible segfaults in hardsubx_classifier.c due to strdup ### 📊 Changes **1 file changed** (+20 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/hardsubx_classifier.c` (+20 -8) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- `strdup` will give a segmentation fault if the argument passed to it is `NULL`. `TessResultIteratorGetUTF8Text` returns a `char*` which can be `NULL` and we should not call `strdup` directly over it. Once we check if the value returned is not `NULL`, then we can call `strdup`. This also fixes #928. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:18:32 +00:00

claunia closed this issue

2026-01-29 17:18:32 +00:00

claunia referenced this issue

2026-01-29 17:22:31 +00:00

[PR #1783] [MERGED] [FIX] Handle double-hyphens in XML comments in spupng encoder #2509

claunia referenced this issue

2026-01-29 17:22:32 +00:00

[PR #1783] [FIX] Handle double-hyphens in XML comments in spupng encoder #2513

Sign in to join this conversation.