[PR #71] [MERGED] Fix for .bin/RCWT file generation #963

New Issue

claunia · 2026-01-29T16:57:43Z

claunia commented

2026-01-29 16:57:43 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/71
Author: @canihavesomecoffee
Created: 7/10/2014
Status: ✅ Merged
Merged: 7/12/2014
Merged by: @cfsmp3

Base: master ← Head: master

📝 Commits (2)

63d3071 Merge pull request #1 from CCExtractor/master
bd49f0f Fix for .bin/RCWT file generation

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 src/ccextractor.c (+6 -0)

📄 Description

When not using latin1 charset, we were producing unreadable .bin files.

Fixed by adding a separate case where for an RCWT under no circumstance
BOM's can be added before the header.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/71 **Author:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Created:** 7/10/2014 **Status:** ✅ Merged **Merged:** 7/12/2014 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`63d3071`](https://github.com/CCExtractor/ccextractor/commit/63d30712339bc3fb514b418b8f892a95f6b5ced5) Merge pull request #1 from CCExtractor/master - [`bd49f0f`](https://github.com/CCExtractor/ccextractor/commit/bd49f0f959552f8295c915b9ab580a8bfd523894) Fix for .bin/RCWT file generation ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/ccextractor.c` (+6 -0) </details> ### 📄 Description When not using latin1 charset, we were producing unreadable .bin files. Fixed by adding a separate case where for an RCWT under no circumstance BOM's can be added before the header. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:57:44 +00:00

claunia referenced this issue

2026-01-29 17:18:32 +00:00

[PR #963] [MERGED] [FIX] Fix possible segfaults in hardsubx_classifier.c due to strdup #1783

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#963