[PR #92] [MERGED] Fill RPM and DEB Vendor, Description and URL #228

Open
opened 2026-01-29 16:31:24 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/quamotion/dotnet-packaging/pull/92
Author: @stop-cran
Created: 2/18/2019
Status: Merged
Merged: 2/19/2019
Merged by: @qmfrederik

Base: masterHead: master


📝 Commits (3)

  • 409450f Add vendor, description and URL to RPM metadata.
  • a2cac0a Use Description (if specified) as a default for PackageDescription.
  • 534855b Use Authors (if specified) as a default for PackageMaintainer (deb).

📊 Changes

6 files changed (+90 additions, -10 deletions)

View changed files

📝 Packaging.Targets.Tests/Rpm/PlistMetadata.cs (+0 -3)
📝 Packaging.Targets.Tests/Rpm/RpmMetadataTests.cs (+3 -0)
📝 Packaging.Targets.Tests/Rpm/RpmPackageCreatorTests.cs (+13 -0)
📝 Packaging.Targets/Rpm/RpmPackageCreator.cs (+32 -3)
📝 Packaging.Targets/RpmTask.cs (+30 -0)
📝 Packaging.Targets/build/Packaging.Targets.targets (+12 -4)

📄 Description

See this issue.
Added 3 corresponding properties for RpmTask. Also amended .targets file for DebTask to take Authors MSBuild property as a default for PackageMaintainer and Description - for PackageDescription. The last should be useful, because Visual Studio UI fills Description property by default - see https://docs.microsoft.com/en-us/dotnet/core/tools/csproj#description.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/quamotion/dotnet-packaging/pull/92 **Author:** [@stop-cran](https://github.com/stop-cran) **Created:** 2/18/2019 **Status:** ✅ Merged **Merged:** 2/19/2019 **Merged by:** [@qmfrederik](https://github.com/qmfrederik) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`409450f`](https://github.com/quamotion/dotnet-packaging/commit/409450f19b1d6664120f813be93de042fc1cf45d) Add vendor, description and URL to RPM metadata. - [`a2cac0a`](https://github.com/quamotion/dotnet-packaging/commit/a2cac0af7d8293ca8b3fb84f4c3d8110272df92f) Use Description (if specified) as a default for PackageDescription. - [`534855b`](https://github.com/quamotion/dotnet-packaging/commit/534855bde721d69d4d52d1bbd561401112f7ccdf) Use Authors (if specified) as a default for PackageMaintainer (deb). ### 📊 Changes **6 files changed** (+90 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `Packaging.Targets.Tests/Rpm/PlistMetadata.cs` (+0 -3) 📝 `Packaging.Targets.Tests/Rpm/RpmMetadataTests.cs` (+3 -0) 📝 `Packaging.Targets.Tests/Rpm/RpmPackageCreatorTests.cs` (+13 -0) 📝 `Packaging.Targets/Rpm/RpmPackageCreator.cs` (+32 -3) 📝 `Packaging.Targets/RpmTask.cs` (+30 -0) 📝 `Packaging.Targets/build/Packaging.Targets.targets` (+12 -4) </details> ### 📄 Description See [this](https://github.com/qmfrederik/dotnet-packaging/issues/91) issue. Added 3 corresponding properties for `RpmTask`. Also amended .targets file for `DebTask` to take `Authors` MSBuild property as a default for `PackageMaintainer` and `Description` - for `PackageDescription`. The last should be useful, because Visual Studio UI fills `Description` property by default - see https://docs.microsoft.com/en-us/dotnet/core/tools/csproj#description. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:31:24 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dotnet-packaging#228