mirror of
https://github.com/quamotion/dotnet-packaging.git
synced 2026-02-15 21:35:27 +00:00
[PR #92] [MERGED] Fill RPM and DEB Vendor, Description and URL #228
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/quamotion/dotnet-packaging/pull/92
Author: @stop-cran
Created: 2/18/2019
Status: ✅ Merged
Merged: 2/19/2019
Merged by: @qmfrederik
Base:
master← Head:master📝 Commits (3)
409450fAdd vendor, description and URL to RPM metadata.a2cac0aUse Description (if specified) as a default for PackageDescription.534855bUse Authors (if specified) as a default for PackageMaintainer (deb).📊 Changes
6 files changed (+90 additions, -10 deletions)
View changed files
📝
Packaging.Targets.Tests/Rpm/PlistMetadata.cs(+0 -3)📝
Packaging.Targets.Tests/Rpm/RpmMetadataTests.cs(+3 -0)📝
Packaging.Targets.Tests/Rpm/RpmPackageCreatorTests.cs(+13 -0)📝
Packaging.Targets/Rpm/RpmPackageCreator.cs(+32 -3)📝
Packaging.Targets/RpmTask.cs(+30 -0)📝
Packaging.Targets/build/Packaging.Targets.targets(+12 -4)📄 Description
See this issue.
Added 3 corresponding properties for
RpmTask. Also amended .targets file forDebTaskto takeAuthorsMSBuild property as a default forPackageMaintainerandDescription- forPackageDescription. The last should be useful, because Visual Studio UI fillsDescriptionproperty by default - see https://docs.microsoft.com/en-us/dotnet/core/tools/csproj#description.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.