mirror of
https://github.com/quamotion/dotnet-packaging.git
synced 2026-02-14 21:32:52 +00:00
The output flag interprets paths relative to the project directory
#92
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AnthonyMastrean on GitHub (Dec 9, 2020).
When I use the
outputflag ondotnet publish, for example, the path is relative to the current working directory (cwd).When I use the
outputflag ondotnet tarball, for example, the path is relative to the project directory.It doesn't print that way (I'll open another issue about complete paths), but I can guarantee that path is relative to the project dir, which is unexpected and inconsistent with the
dotnetCLI.@qmfrederik commented on GitHub (Dec 9, 2020):
The idea is indeed that these commands are similar to the
dotnetCLI in behavior. So that does mean thatdotnet tarball -o [path]should interpretpathas relative to the working directory (similar todotnet packordotnet publish).The code that handles this is here: https://github.com/qmfrederik/dotnet-packaging/blob/master/Packaging.Targets/TarballTask.cs#L30 (and similar for the other commands).
Are you interested in creating a PR for this?
@Chris-Mingay commented on GitHub (Aug 17, 2021):
Hi @qmfrederik I am interested in helping with this but I'm not actually sure how I go about using my locally compiled version of
dotnet-zipto test what I have coded.If you're happy to point me in the right direction with that, I'll get things coded and create a pull request.
Thanks