starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

GameList: Log image open errors on file scan failure

Browse Source
This commit is contained in:
Stenzek
2026-01-14 21:26:51 +10:00
parent 0c84baf4da
commit d02382da79
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/core/game_list.cpp
View File

@@ -274,10 +274,11 @@ bool GameList::GetExeListEntry(const std::string& path, GameList::Entry* entry)
entry->region = BIOS::GetPSExeDiscRegion(header);
}
const auto data = FileSystem::ReadBinaryFile(fp.get());
Error error;
const auto data = FileSystem::ReadBinaryFile(fp.get(), &error);
if (!data.has_value())
{
WARNING_LOG("Failed to read {}", path);
WARNING_LOG("Failed to read {}: {}", Path::GetFileName(path), error.GetDescription());
return false;
}
@@ -289,9 +290,13 @@ bool GameList::GetExeListEntry(const std::string& path, GameList::Entry* entry)
bool GameList::GetPsfListEntry(const std::string& path, Entry* entry)
{
// we don't need to walk the library chain here - the top file is enough
Error error;
PSFLoader::File file;
if (!file.Load(path.c_str(), nullptr))
if (!file.Load(path.c_str(), &error))
{
ERROR_LOG("Failed to load PSF file '{}': {}", Path::GetFileName(path), error.GetDescription());
return false;
}
entry->serial.clear();
entry->region = file.GetRegion();
@@ -327,9 +332,13 @@ bool GameList::GetPsfListEntry(const std::string& path, Entry* entry)
bool GameList::GetDiscListEntry(const std::string& path, Entry* entry)
{
std::unique_ptr<CDImage> cdi = CDImage::Open(path.c_str(), false, nullptr);
Error error;
std::unique_ptr<CDImage> cdi = CDImage::Open(path.c_str(), false, &error);
if (!cdi)
{
ERROR_LOG("Failed to open disc image '{}': {}", Path::GetFileName(path), error.GetDescription());
return false;
}
entry->path = path;
entry->file_size = cdi->GetSizeOnDisk();