mirror of
https://github.com/genesi/linux-legacy.git
synced 2026-02-04 05:35:07 +00:00
ipc ns: fix memory leak (idr)
commit 7d6feeb287c61aafa88f06345387b1188edf4b86 upstream.
We have apparently had a memory leak since
7ca7e564e0 "ipc: store ipcs into IDRs" in
2007. The idr of which 3 exist for each ipc namespace is never freed.
This patch simply frees them when the ipcns is freed. I don't believe any
idr_remove() are done from rcu (and could therefore be delayed until after
this idr_destroy()), so the patch should be safe. Some quick testing
showed no harm, and the memory leak fixed.
Caught by kmemleak.
Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
b453242d28
commit
4bd80d9955
@@ -125,6 +125,7 @@ void msg_init_ns(struct ipc_namespace *ns)
|
||||
void msg_exit_ns(struct ipc_namespace *ns)
|
||||
{
|
||||
free_ipcs(ns, &msg_ids(ns), freeque);
|
||||
idr_destroy(&ns->ids[IPC_MSG_IDS].ipcs_idr);
|
||||
}
|
||||
#endif
|
||||
|
||||
|
||||
@@ -129,6 +129,7 @@ void sem_init_ns(struct ipc_namespace *ns)
|
||||
void sem_exit_ns(struct ipc_namespace *ns)
|
||||
{
|
||||
free_ipcs(ns, &sem_ids(ns), freeary);
|
||||
idr_destroy(&ns->ids[IPC_SEM_IDS].ipcs_idr);
|
||||
}
|
||||
#endif
|
||||
|
||||
|
||||
Reference in New Issue
Block a user