starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-04 05:44:50 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

Improve RenderBase optimization with Type.GetTypeHandle (#632)

Browse Source
This commit is contained in:
Alexandre Mutel
2022-04-23 16:20:52 +02:00
parent f09d030fd3
commit 210b39e8fb
1 changed files with 38 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
src/Markdig/Renderers/RendererBase.cs
View File

@@ -4,9 +4,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using Markdig.Helpers;
using Markdig.Syntax;
using Markdig.Syntax.Inlines;
@@ -19,7 +17,7 @@ namespace Markdig.Renderers
/// <seealso cref="IMarkdownRenderer" />
public abstract class RendererBase : IMarkdownRenderer
{
private readonly Dictionary<Type, IMarkdownObjectRenderer?> _renderersPerType = new();
private readonly Dictionary<KeyWrapper, IMarkdownObjectRenderer?> _renderersPerType = new();
internal int _childrenDepth = 0;
/// <summary>
@@ -27,6 +25,25 @@ namespace Markdig.Renderers
/// </summary>
protected RendererBase() { }
private IMarkdownObjectRenderer? GetRendererInstance(MarkdownObject obj)
{
KeyWrapper key = GetKeyForType(obj);
Type objectType = obj.GetType();
for (int i = 0; i < ObjectRenderers.Count; i++)
{
var renderer = ObjectRenderers[i];
if (renderer.Accept(this, objectType))
{
_renderersPerType[key] = renderer;
return renderer;
}
}
_renderersPerType[key] = null;
return null;
}
public ObjectRendererCollection ObjectRenderers { get; } = new();
public abstract object Render(MarkdownObject markdownObject);
@@ -124,10 +141,9 @@ namespace Markdig.Renderers
// Calls before writing an object
ObjectWriteBefore?.Invoke(this, obj);
var objectType = obj.GetType();
if (!_renderersPerType.TryGetValue(objectType, out IMarkdownObjectRenderer? renderer))
if (!_renderersPerType.TryGetValue(GetKeyForType(obj), out IMarkdownObjectRenderer? renderer))
{
renderer = GetRendererInstance(objectType);
renderer = GetRendererInstance(obj);
}
if (renderer is not null)
@@ -147,20 +163,24 @@ namespace Markdig.Renderers
ObjectWriteAfter?.Invoke(this, obj);
}
private IMarkdownObjectRenderer? GetRendererInstance(Type objectType)
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static KeyWrapper GetKeyForType(MarkdownObject obj)
{
var renderers = ObjectRenderers;
foreach (var renderer in renderers)
{
if (renderer.Accept(this, objectType))
{
_renderersPerType[objectType] = renderer;
return renderer;
}
}
IntPtr typeHandle = Type.GetTypeHandle(obj).Value;
return new KeyWrapper(typeHandle);
}
_renderersPerType[objectType] = null;
return null;
private readonly struct KeyWrapper : IEquatable<KeyWrapper>
{
public readonly IntPtr Key;
public KeyWrapper(IntPtr key) => Key = key;
public bool Equals(KeyWrapper other) => Key == other.Key;
public override int GetHashCode() => Key.GetHashCode();
public override bool Equals(object? obj) => throw new NotImplementedException();
}
}
}