starred/qemu-qemu-1
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:56:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

dump: make win_dump_available() check vmcoreinfo for a Windows dump header

Browse Source 
QMP query-dump-guest-memory-capability reports win-dmp as available for
any x86 VM, and dump-guest-memory accepts the win-dmp format
unconditionally. Both are wrong: win-dmp only works when the guest has
published a Windows dump header through vmcoreinfo.

The guest registers that note with the vmcoreinfo device (its physical
address and size), so win_dump_available() can read it back directly and
validate the note size and the Windows dump header signature. This needs
no other guest state, so it does not stop the vCPUs.

The capability query reads the note on the main thread with the BQL held
and has no migration guard of its own, so it is skipped while a migration
destination is still receiving guest RAM: there the read would deadlock
against the postcopy load (which needs the BQL) or, in precopy, see
incomplete pages.

Based on the original work of Nikolai Barybin.

Signed-off-by: Denis V. Lunev <den@openvz.org>
[ MA - changed physical_memory_read() call ]
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20260619101834.228432-5-den@openvz.org>
This commit is contained in:
Denis V. Lunev
2026-06-19 12:18:31 +02:00
committed by Marc-André Lureau
parent 19e8b59626
commit 1c0e259c5a
1 changed files with 44 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
dump/win_dump-x86.c
View File

@@ -18,11 +18,10 @@
#include "qemu/win_dump_defs.h"
#include "win_dump.h"
#include "cpu.h"
bool win_dump_available(Error **errp)
{
return true;
}
#include "qemu/bswap.h"
#include "hw/misc/vmcoreinfo.h"
#include "migration/misc.h"
#include "standard-headers/linux/qemu_fw_cfg.h"
static size_t win_dump_ptr_size(bool x64)
{
@@ -404,6 +403,46 @@ static void restore_context(WinDumpHeader *h, bool x64,
}
}
bool win_dump_available(Error **errp)
{
VMCoreInfoState *vmci = vmcoreinfo_find();
g_autofree uint8_t *note = NULL;
Error *local_err = NULL;
WinDumpHeader *h;
uint32_t size;
bool x64 = true;
if (migration_guest_ram_loading()) {
error_setg(errp, "win-dump: not available during migration");
return false;
}
if (!vmci || !vmci->has_vmcoreinfo ||
le16_to_cpu(vmci->vmcoreinfo.guest_format) !=
FW_CFG_VMCOREINFO_FORMAT_ELF) {
error_setg(errp, "win-dump: no vmcoreinfo note from the guest");
return false;
}
size = le32_to_cpu(vmci->vmcoreinfo.size);
if (size != VMCOREINFO_WIN_DUMP_NOTE_SIZE32 &&
size != VMCOREINFO_WIN_DUMP_NOTE_SIZE64) {
error_setg(errp, "win-dump: invalid vmcoreinfo note size");
return false;
}
note = g_malloc(size);
physical_memory_read(le64_to_cpu(vmci->vmcoreinfo.paddr), note, size);
h = (void *)(note + VMCOREINFO_ELF_NOTE_HDR_SIZE);
if (!check_header(h, &x64, &local_err)) {
error_propagate(errp, local_err);
return false;
}
return true;
}
void create_win_dump(DumpState *s, Error **errp)
{
WinDumpHeader *h = (void *)(s->guest_note + VMCOREINFO_ELF_NOTE_HDR_SIZE);