starred/qemu-qemu-1
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:56:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

block: Improve readability in HMP 'info blockstats' output

Browse Source 
Instead of a long line with key=value pairs for each block device,
switch to a tabular form with aligned values. This makes it much easier
to find the relevant information in the output.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20260512112759.66038-1-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Kevin Wolf
2026-05-12 13:27:59 +02:00
parent e3082ab3b3
commit 8b663f7d0d
1 changed files with 21 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
block/monitor/block-hmp-cmds.c
View File

@@ -794,30 +794,28 @@ void hmp_info_blockstats(Monitor *mon, const QDict *qdict)
continue;
}
monitor_printf(mon, "%s:", stats->value->device);
monitor_printf(mon, " rd_bytes=%" PRId64
" wr_bytes=%" PRId64
" rd_operations=%" PRId64
" wr_operations=%" PRId64
" flush_operations=%" PRId64
" wr_total_time_ns=%" PRId64
" rd_total_time_ns=%" PRId64
" flush_total_time_ns=%" PRId64
" rd_merged=%" PRId64
" wr_merged=%" PRId64
" idle_time_ns=%" PRId64
"\n",
stats->value->stats->rd_bytes,
stats->value->stats->wr_bytes,
stats->value->stats->rd_operations,
stats->value->stats->wr_operations,
stats->value->stats->flush_operations,
stats->value->stats->wr_total_time_ns,
stats->value->stats->rd_total_time_ns,
stats->value->stats->flush_total_time_ns,
stats->value->stats->rd_merged,
stats->value->stats->wr_merged,
monitor_printf(mon, "%s%s: idle_time_ns=%" PRId64 "\n",
stats != stats_list ? "\n" : "",
stats->value->device,
stats->value->stats->idle_time_ns);
monitor_printf(mon, " %24s %16s %24s %10s\n", "bytes",
"operations", "total_time_ns", "merged");
monitor_printf(mon, "Read: %24" PRId64 " %16" PRId64 " %24" PRId64
" %10" PRId64 "\n",
stats->value->stats->rd_bytes,
stats->value->stats->rd_operations,
stats->value->stats->rd_total_time_ns,
stats->value->stats->rd_merged);
monitor_printf(mon, "Write: %24" PRId64 " %16" PRId64 " %24" PRId64
" %10" PRId64 "\n",
stats->value->stats->wr_bytes,
stats->value->stats->wr_operations,
stats->value->stats->wr_total_time_ns,
stats->value->stats->wr_merged);
monitor_printf(mon, "Flush: %24s %16" PRId64 " %24" PRId64 "\n",
"",
stats->value->stats->flush_operations,
stats->value->stats->flush_total_time_ns);
}
qapi_free_BlockStatsList(stats_list);