starred/qemu-qemu-1
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-02-04 02:24:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

hw/char/cmsdk-apb-uart.c: log guest_errors for r/w to disabled uart

Browse Source 
I don't want to admit how many hours I spent trying to figure out why
nothing was being printed (as the enable-ing code hadn't yet run,
even thought it existed).

Signed-off-by: julia <midnight@trainwit.ch>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20251217-cmsdk-uart-disabled-warning2-v1-1-847de48840bc@trainwit.ch
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
julia
2026-01-15 15:26:29 +00:00
committed by Peter Maydell
parent bb5ce7dc56
commit 9111971f33
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
hw/char/cmsdk-apb-uart.c
View File

@@ -159,6 +159,10 @@ static uint64_t uart_read(void *opaque, hwaddr offset, unsigned size)
switch (offset) {
case A_DATA:
r = s->rxbuf;
if (!(s->ctrl & R_CTRL_RX_EN_MASK)) {
qemu_log_mask(LOG_GUEST_ERROR,
"CMSDK APB UART: receive data read with Rx disabled\n");
}
s->state &= ~R_STATE_RXFULL_MASK;
cmsdk_apb_uart_update(s);
qemu_chr_fe_accept_input(&s->chr);
@@ -248,6 +252,10 @@ static void uart_write(void *opaque, hwaddr offset, uint64_t value,
switch (offset) {
case A_DATA:
s->txbuf = value;
if (!(s->ctrl & R_CTRL_TX_EN_MASK)) {
qemu_log_mask(LOG_GUEST_ERROR,
"CMSDK APB UART: transmit data write with Tx disabled\n");
}
if (s->state & R_STATE_TXFULL_MASK) {
/* Buffer already full -- note the overrun and let the
* existing pending transmit callback handle the new char.