starred/qemu-qemu-1
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:56:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

hw/pci-bridge: handle missing parent in prop_pxb_uid_get

Browse Source 
When called on an unrealized pxb bus (e.g. from
qmp_qom_list_properties), bus->parent_dev is NULL. The pxb_bus_num()
callback dereferences it unconditionally. Check for this to avoid a
NULL dereference.

Fixes: 97b9cb066e ("hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS")
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This commit is contained in:
Marc-André Lureau
2026-04-24 19:04:47 +04:00
parent 6f4544f54d
commit ce2e8408a1
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
hw/pci-bridge/pci_expander_bridge.c
View File

@@ -85,8 +85,14 @@ static uint16_t pxb_bus_numa_node(PCIBus *bus)
static void prop_pxb_uid_get(Object *obj, Visitor *v, const char *name,
void *opaque, Error **errp)
{
uint32_t uid = pci_bus_num(PCI_BUS(obj));
PCIBus *bus = PCI_BUS(obj);
uint32_t uid;
if (!bus->parent_dev) {
error_setg(errp, "bus not attached to a device");
return;
}
uid = pci_bus_num(bus);
visit_type_uint32(v, name, &uid, errp);
}