starred/qemu-qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:46:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hexagon (target/hexagon) Check each opcode against current CPU definition

Browse Source 
During decoding, check that the opcode is supported in the current
Hexagon CPU definition

Co-authored-by: Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>
Co-authored-by: Brian Cain <brian.cain@oss.qualcomm.com>
Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
This commit is contained in:
Taylor Simpson
2026-02-17 14:22:42 -07:00
committed by Brian Cain
parent cdc04900ba
commit 0507495604
2 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
target/hexagon/decode.c
View File

@@ -647,6 +647,22 @@ decode_set_slot_number(Packet *pkt)
return has_valid_slot_assignment(pkt);
}
bool opcode_supported(uint16_t opcode, const HexagonCPUDef *hex_def)
{
HexagonVersion hex_version = hex_def->hex_version;
#include "tag_rev_info.c.inc"
struct tag_rev_info info = tag_rev_info[opcode];
if (hex_version == HEX_VER_ANY) {
return true;
}
if ((info.introduced != HEX_VER_NONE && hex_version < info.introduced) ||
(info.removed != HEX_VER_NONE && hex_version >= info.removed)) {
return false;
}
return true;
}
/*
* Check for GPR write conflicts in the packet.
* A conflict exists when a register is written by more than one instruction
@@ -746,6 +762,17 @@ int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,
/* Ran out of words! */
return 0;
}
/*
* Check that all the opcodes are supported in this Hexagon definition
* If not, return decode error
*/
for (i = 0; i < num_insns; i++) {
if (!opcode_supported(pkt->insn[i].opcode, ctx->hex_def)) {
return 0;
}
}
pkt->encod_pkt_size_in_bytes = words_read * 4;
pkt->pkt_has_hvx = false;
for (i = 0; i < num_insns; i++) {

2
target/hexagon/decode.h
View File

@@ -30,4 +30,6 @@ void decode_send_insn_to(Packet *packet, int start, int newloc);
int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,
Packet *pkt, bool disas_only);
bool opcode_supported(uint16_t opcode, const HexagonCPUDef *hex_def);
#endif