starred/qemu-qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:46:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

hw/arm/aspeed_ast27x0-{ssp, tsp}: Do not access SerialMM internals directly

Browse Source 
SerialMM inherits from SysBusDevice and exposes the memory region by
means of sysbus_mmio_get_region(). Use that in order to avoid accessing
implementation details of SerialMM.

Reviewed-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Message-ID: <20260305220911.131508-4-shentey@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Bernhard Beschow
2026-03-05 23:09:00 +01:00
committed by Philippe Mathieu-Daudé
parent 7e68ad18f5
commit 79c0b57251
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
hw/arm/aspeed_ast27x0-ssp.c
View File

@@ -149,6 +149,7 @@ static void aspeed_soc_ast27x0ssp_realize(DeviceState *dev_soc, Error **errp)
AspeedCoprocessorState *s = ASPEED_COPROCESSOR(dev_soc);
AspeedCoprocessorClass *sc = ASPEED_COPROCESSOR_GET_CLASS(s);
DeviceState *armv7m;
MemoryRegion *mr;
g_autofree char *sdram_name = NULL;
int i;
@@ -230,9 +231,9 @@ static void aspeed_soc_ast27x0ssp_realize(DeviceState *dev_soc, Error **errp)
}
/* UART */
memory_region_init_alias(&s->uart_alias, OBJECT(s), "uart.alias",
&s->uart->serial.io, 0,
memory_region_size(&s->uart->serial.io));
mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(s->uart), 0);
memory_region_init_alias(&s->uart_alias, OBJECT(s), "uart.alias", mr, 0,
memory_region_size(mr));
memory_region_add_subregion(s->memory, sc->memmap[s->uart_dev],
&s->uart_alias);
/*

7
hw/arm/aspeed_ast27x0-tsp.c
View File

@@ -149,6 +149,7 @@ static void aspeed_soc_ast27x0tsp_realize(DeviceState *dev_soc, Error **errp)
AspeedCoprocessorState *s = ASPEED_COPROCESSOR(dev_soc);
AspeedCoprocessorClass *sc = ASPEED_COPROCESSOR_GET_CLASS(s);
DeviceState *armv7m;
MemoryRegion *mr;
g_autofree char *sdram_name = NULL;
int i;
@@ -230,9 +231,9 @@ static void aspeed_soc_ast27x0tsp_realize(DeviceState *dev_soc, Error **errp)
}
/* UART */
memory_region_init_alias(&s->uart_alias, OBJECT(s), "uart.alias",
&s->uart->serial.io, 0,
memory_region_size(&s->uart->serial.io));
mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(s->uart), 0);
memory_region_init_alias(&s->uart_alias, OBJECT(s), "uart.alias", mr, 0,
memory_region_size(mr));
memory_region_add_subregion(s->memory, sc->memmap[s->uart_dev],
&s->uart_alias);
/*