starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:46:10 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

system/cpus: refuse memsave/pmemsave while guest RAM is being migrated

Browse Source 
memsave and pmemsave read guest memory and write it to a file, with no
guard at all. They run on the main thread with the BQL held, so on a
postcopy destination touching a not-yet-received page deadlocks: the
thread blocks on the userfault while the postcopy incoming path waits for
the BQL to install that page. During precopy the read returns incomplete
state instead.

Refuse both while guest RAM is still being received, using the same
migration_guest_ram_loading() check as dump-guest-memory.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20260619101834.228432-4-den@openvz.org>
This commit is contained in:
Denis V. Lunev
2026-06-19 12:18:30 +02:00
committed by Marc-André Lureau
parent 9d9d449180
commit 19e8b59626
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
system/cpus.c
View File

@@ -43,6 +43,7 @@
#include "system/physmem.h"
#include "system/replay.h"
#include "system/runstate.h"
#include "migration/misc.h"
#include "system/cpu-timers.h"
#include "system/whpx.h"
#include "hw/core/boards.h"
@@ -843,6 +844,11 @@ void qmp_memsave(uint64_t addr, uint64_t size, const char *filename,
uint8_t buf[1024];
uint64_t orig_addr = addr, orig_size = size;
if (migration_guest_ram_loading()) {
error_setg(errp, "Guest memory access not allowed during migration");
return;
}
if (!has_cpu) {
cpu_index = 0;
}
@@ -889,6 +895,11 @@ void qmp_pmemsave(uint64_t addr, uint64_t size, const char *filename,
uint64_t l;
uint8_t buf[1024];
if (migration_guest_ram_loading()) {
error_setg(errp, "Guest memory access not allowed during migration");
return;
}
f = fopen(filename, "wb");
if (!f) {
error_setg_file_open(errp, errno, filename);