starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:46:10 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

monitor: add 'readline' property to HMP Monitor class

Browse Source 
This determines whether a human monitor runs with readline for
interactive use, or without readline for non-interactive use by
the GDB stub.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Tested-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20260706135824.2623960-9-berrange@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
Daniel P. Berrangé
2026-07-06 14:57:56 +01:00
committed by Markus Armbruster
parent 1a65434329
commit 1a618b2ddd
1 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
monitor/hmp.c
View File

@@ -50,12 +50,37 @@ static void monitor_hmp_finalize(Object *obj)
{
}
static bool monitor_hmp_get_readline(Object *obj, Error **errp)
{
MonitorHMP *mon = MONITOR_HMP(obj);
return mon->use_readline;
}
static void monitor_hmp_set_readline(Object *obj, bool val, Error **errp)
{
MonitorHMP *mon = MONITOR_HMP(obj);
mon->use_readline = val;
}
static void monitor_hmp_class_init(ObjectClass *cls, const void *data)
{
object_class_property_add_bool(cls, "readline",
monitor_hmp_get_readline,
monitor_hmp_set_readline);
}
static void monitor_hmp_init(Object *obj)
{
MonitorHMP *hmp = MONITOR_HMP(obj);
/*
* Default to common case for external HMP use,
* as opposed to non-interactive internal use
* from gdbstub
*/
hmp->use_readline = true;
}
static void monitor_command_cb(void *opaque, const char *cmdline,
@@ -1550,6 +1575,7 @@ void monitor_new_hmp(const char *id, const char *chardev_id,
id ? id : autoid,
errp,
"chardev", chardev_id,
"readline", use_readline ? "yes" : "no",
NULL);
if (!obj) {
@@ -1566,7 +1592,6 @@ void monitor_new_hmp(const char *id, const char *chardev_id,
monitor_data_init(&mon->parent_obj, false, false, false);
mon->use_readline = use_readline;
if (mon->use_readline) {
mon->rs = readline_init(monitor_readline_printf,
monitor_readline_flush,