starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:46:10 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

tests/qtest/ast2700-gpio-test: Use g_strdup_printf() instead of char arrays

Browse Source 
Older versions of gcc with -Wformat-overflow=2 don't like the usage of
fixed size char arrays in this test; gcc 7.5.0 (SUSE Linux) says:

../tests/qtest/ast2700-gpio-test.c: In function ‘test_input_pins’:
../tests/qtest/ast2700-gpio-test.c:54:36: error: ‘sprintf’ may write a terminating nul past the end of the destination [-Werror=format-overflow=]
             sprintf(name, "gpio%c%d", c, i);
                                    ^
../tests/qtest/ast2700-gpio-test.c:54:13: note: ‘sprintf’ output between 7 and 17 bytes into a destination of size 16
             sprintf(name, "gpio%c%d", c, i);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This can't actually happen because of the limited size of the values
being substituted in.  However rather than require readers to check
whether the arrays really have been declared large enough, we prefer
to use g_strdup_printf() for this kind of string work.

Reported-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20260310153334.3063224-2-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell
2026-03-10 15:33:33 +00:00
parent 62272f9f88
commit 1d3926e271
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/qtest/ast2700-gpio-test.c
View File

@@ -44,14 +44,13 @@ static void test_output_pins(const char *machine, const uint32_t base)
static void test_input_pins(const char *machine, const uint32_t base)
{
QTestState *s = qtest_init(machine);
char name[16];
uint32_t offset = 0;
uint32_t value = 0;
uint32_t pin = 0;
for (char c = 'A'; c <= 'D'; c++) {
for (int i = 0; i < 8; i++) {
sprintf(name, "gpio%c%d", c, i);
g_autofree const char *name = g_strdup_printf("gpio%c%d", c, i);
offset = base + (pin * 4);
/* input direction */
qtest_writel(s, offset, 0);