starred/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2026-07-08 17:46:10 +00:00
Code Issues 380 Packages Projects Releases Wiki Activity

scripts/checkpatch: ignore spaces required around some operators in C++

Browse Source 
C++ has a different style when it comes to space around references,
dereferences, so don't report it.
Also, closing templates with >> gets wrongly confused with >> operator,
so just relax this check.

Some examples:
ERROR: spaces required around that '&' (ctx:WxV)
+                auto &[counter, p] = *static_cast<TbData*>(udata);
                      ^

ERROR: spaces required around that '*' (ctx:VxO)
+                auto &[counter, p] = *static_cast<TbData*>(udata);
                                                         ^

ERROR: spaces required around that '>>' (ctx:VxW)
+        std::vector<std::pair<Vaddr, uint64_t>> v;                                              ^

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Link: https://lore.kernel.org/qemu-devel/20260615193526.2883349-25-pierrick.bouvier@oss.qualcomm.com
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
This commit is contained in:
Pierrick Bouvier
2026-06-15 12:35:23 -07:00
parent 13c6930028
commit 320de9f89f
1 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
scripts/checkpatch.pl
View File

@@ -2621,6 +2621,31 @@ sub process {
if ($op eq '::') {
$ok = 1;
}
# Ignore * in C++: templates and
# pointer types are incorrectly
# flagged. Example:
# static_cast<T*>
if ($op eq '*') {
$ok = 1;
}
# Ignore & in C++: & means a
# reference, and this create
# issues with some constructions.
# Example:
# auto &[first, second] = pair;
if ($op eq '&') {
$ok = 1;
}
# Ignore >> in C++
# checkpatch is confused by
# >> closing templates. Example:
# vector<pair<A, B>>
if ($op eq '>>') {
$ok = 1;
}
}
# Ignore email addresses <foo@bar>