mirror of
https://github.com/qemu/qemu.git
synced 2026-04-05 22:00:58 +00:00
system/physmem.c: remove useless assertion of block
It is useless to assert that block is not NULL because it is already dereferenced in the first line of the function. The assertion is also unnecessary because the function is called in only two places, and `block` can't be NULL in either of them: - In `migration/ram.c`, we have already dereferenced `block` in the code just before the call. - In `system/memory.c`, we assert `mr->ram_block` before passing it to the function. (We could split the declaration and initialization of oldsize, but then we would need to remove the const qualifier. As the assertion is useless anyway, removing the const qualifier seems worse.) Signed-off-by: Sergei Heifetz <heifetz@yandex-team.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Peter Xu <peterx@redhat.com> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
committed by
Michael Tokarev
parent
de49227611
commit
731abcf418
@@ -2028,8 +2028,6 @@ int qemu_ram_resize(RAMBlock *block, ram_addr_t newsize, Error **errp)
|
||||
const ram_addr_t oldsize = block->used_length;
|
||||
const ram_addr_t unaligned_size = newsize;
|
||||
|
||||
assert(block);
|
||||
|
||||
newsize = TARGET_PAGE_ALIGN(newsize);
|
||||
newsize = REAL_HOST_PAGE_ALIGN(newsize);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user