starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-09-24 07:54:39 +00:00
Code Issues 975 Packages Projects Releases 25 Wiki Activity

Use ArrayPool for temporary buffers in BinaryReaderExtensions

Browse Source 
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-01-03 17:12:43 +00:00
parent 1a71c01fd4
commit 05642cbdc6
1 changed files with 26 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/SharpCompress/Polyfills/BinaryReaderExtensions.cs
View File

@@ -11,11 +11,18 @@ public static class BinaryReaderExtensions
{
public async Task<byte> ReadByteAsync(CancellationToken cancellationToken = default)
{
var buffer = new byte[1];
await reader
.BaseStream.ReadExactAsync(buffer, 0, 1, cancellationToken)
.ConfigureAwait(false);
return buffer[0];
var buffer = ArrayPool<byte>.Shared.Rent(1);
try
{
await reader
.BaseStream.ReadExactAsync(buffer, 0, 1, cancellationToken)
.ConfigureAwait(false);
return buffer[0];
}
finally
{
ArrayPool<byte>.Shared.Return(buffer);
}
}
public async Task<byte[]> ReadBytesAsync(
@@ -23,11 +30,20 @@ public static class BinaryReaderExtensions
CancellationToken cancellationToken = default
)
{
var bytes = new byte[count];
await reader
.BaseStream.ReadExactAsync(bytes, 0, count, cancellationToken)
.ConfigureAwait(false);
return bytes;
var buffer = ArrayPool<byte>.Shared.Rent(count);
try
{
await reader
.BaseStream.ReadExactAsync(buffer, 0, count, cancellationToken)
.ConfigureAwait(false);
var bytes = new byte[count];
System.Array.Copy(buffer, 0, bytes, 0, count);
return bytes;
}
finally
{
ArrayPool<byte>.Shared.Return(buffer);
}
}
}
}