starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-09-22 06:54:40 +00:00
Code Issues 975 Packages Projects Releases 25 Wiki Activity

Fix sym link tests

Browse Source
This commit is contained in:
Adam Hathcock
2026-08-05 14:33:19 +01:00
committed by Adam Hathcock
parent b97cce5ef1
commit a25ef129a4
1 changed files with 35 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tests/SharpCompress.Test/Security/SymbolicLinkExtractionTests.cs
View File

@@ -1,5 +1,6 @@
#if NET8_0_OR_GREATER
using System;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Text;
@@ -41,7 +42,7 @@ public class SymbolicLinkExtractionTests : TestBase
var exception = await ExtractAsync(api, archivePath, destinationDirectory, options);
var extractionException = Assert.IsType<ExtractionException>(exception);
Assert.Contains("symbolic link outside", extractionException.Message);
Assert.Contains("symbolic link whose target is outside", extractionException.Message);
Assert.Equal(0, handlerCalls);
Assert.False(File.Exists(Path.Combine(outsideDirectory, "secret.txt")));
}
@@ -66,18 +67,47 @@ public class SymbolicLinkExtractionTests : TestBase
SymbolicLinkHandler = (linkPath, linkTarget) =>
{
handlerCalls++;
Directory.CreateSymbolicLink(linkPath, linkTarget);
CreateReparsePoint(linkPath, linkTarget);
},
};
var exception = await ExtractAsync(api, archivePath, destinationDirectory, options);
var extractionException = (await ExtractAsync(api, archivePath, destinationDirectory, options)).NotNull();
var extractionException = Assert.IsType<ExtractionException>(exception);
Assert.Contains("symbolic link or reparse point", extractionException.Message);
Assert.Contains("symbolic link or reparse point", extractionException.ToString());
Assert.Equal(1, handlerCalls);
Assert.False(File.Exists(Path.Combine(targetDirectory, "secret.txt")));
}
private static void CreateReparsePoint(string linkPath, string linkTarget)
{
if (OperatingSystem.IsWindows())
{
// Directory junctions are reparse points that need no elevation, unlike symbolic links.
// Junction targets must be absolute.
var absoluteTarget = Path.GetFullPath(
Path.Combine(Path.GetDirectoryName(linkPath).NotNull(), linkTarget)
);
var startInfo = new ProcessStartInfo("cmd.exe")
{
UseShellExecute = false,
CreateNoWindow = true,
};
startInfo.ArgumentList.Add("/c");
startInfo.ArgumentList.Add("mklink");
startInfo.ArgumentList.Add("/j");
startInfo.ArgumentList.Add(linkPath);
startInfo.ArgumentList.Add(absoluteTarget);
using var process = Process.Start(startInfo).NotNull();
process.WaitForExit();
Assert.Equal(0, process.ExitCode);
}
else
{
Directory.CreateSymbolicLink(linkPath, linkTarget);
}
}
private static void BuildTar(string path, string linkTarget)
{
using var stream = File.Create(path);