Make 0.13.1

Fix null password on ReaderFactory.  Fix null options on SevenZipArchive

FORMATS.md

@@ -28,4 +28,5 @@ For those who want to directly compress/decompress bits
 | GZipStream | Both |
 | DeflateStream | Both |
 | LZMAStream | Both |
-| PPMdStream | Both |
+| PPMdStream | Both |
+| ADCStream | Decompress |

README.md

@@ -9,7 +9,7 @@ The major feature is support for non-seekable streams so large files can be proc
 ## Need Help?
 Post Issues on Github!
 
-Check the [Supported Formats](FORMATS.md) and [basic usage.](USAGE.md)
+Check the [Supported Formats](FORMATS.md) and [Basic Usage.](USAGE.md)
 
 ## A Simple Request
 
@@ -31,25 +31,36 @@ I'm always looking for help or ideas. Please submit code or email with ideas. Un
 
 ## Version Log
 
+### Version 0.13.1
+
+* [Fix null password on ReaderFactory. Fix null options on SevenZipArchive](https://github.com/adamhathcock/sharpcompress/pull/188)
+* [Make PpmdProperties lazy to avoid unnecessary allocations.](https://github.com/adamhathcock/sharpcompress/pull/185)
+
 ### Version 0.13.0
+
 * Breaking change: Big refactor of Options on API.
 * 7Zip supports Deflate
 
 ### Version 0.12.4
+
 * Forward only zip issue fix https://github.com/adamhathcock/sharpcompress/issues/160
 * Try to fix frameworks again by copying targets from JSON.NET
 
 ### Version 0.12.3
+
 * 7Zip fixes https://github.com/adamhathcock/sharpcompress/issues/73
 * Maybe all profiles will work with project.json now
 
 ### Version 0.12.2
+
 * Support Profile 259 again
 
 ### Version 0.12.1
+
 * Support Silverlight 5
 
 ### Version 0.12.0
+
 * .NET Core RTM!
 * Bug fix for Tar long paths
 

src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs

@@ -30,7 +30,7 @@ namespace SharpCompress.Archives.SevenZip
         /// </summary>
         /// <param name="fileInfo"></param>
         /// <param name="readerOptions"></param>
-        public static SevenZipArchive Open(FileInfo fileInfo, ReaderOptions readerOptions)
+        public static SevenZipArchive Open(FileInfo fileInfo, ReaderOptions readerOptions = null)
         {
             fileInfo.CheckNotNull("fileInfo");
             return new SevenZipArchive(fileInfo, readerOptions ?? new ReaderOptions());
@@ -44,7 +44,7 @@ namespace SharpCompress.Archives.SevenZip
         public static SevenZipArchive Open(Stream stream, ReaderOptions readerOptions = null)
         {
             stream.CheckNotNull("stream");
-            return new SevenZipArchive(stream, readerOptions);
+            return new SevenZipArchive(stream, readerOptions ?? new ReaderOptions());
         }
 
 #if !NO_FILE

src/SharpCompress/Common/Volume.cs

@@ -8,10 +8,10 @@ namespace SharpCompress.Common
     {
         private readonly Stream actualStream;
 
-        internal Volume(Stream stream, ReaderOptions readerFactoryOptions)
+        internal Volume(Stream stream, ReaderOptions readerOptions)
         {
             actualStream = stream;
-            ReaderOptions = readerFactoryOptions;
+            ReaderOptions = readerOptions;
         }
 
         internal Stream Stream { get { return new NonDisposingStream(actualStream); } }

src/SharpCompress/Compressors/PPMd/PpmdProperties.cs

@@ -3,13 +3,6 @@ using SharpCompress.Converters;
 
 namespace SharpCompress.Compressors.PPMd
 {
-    public enum PpmdVersion
-    {
-        H,
-        H7z,
-        I1
-    }
-
     public class PpmdProperties
     {
         public PpmdVersion Version = PpmdVersion.I1;

src/SharpCompress/Compressors/PPMd/PpmdVersion.cs

@@ -0,0 +1,9 @@
+namespace SharpCompress.Compressors.PPMd
+{
+    public enum PpmdVersion
+    {
+        H,
+        H7z,
+        I1
+    }
+}

src/SharpCompress/Readers/AbstractReader.cs

@@ -29,7 +29,7 @@ namespace SharpCompress.Readers
             Options = options;
         }
 
-        internal ReaderOptions Options { get; private set; }
+        internal ReaderOptions Options { get; }
 
         public ArchiveType ArchiveType { get; }
 

src/SharpCompress/Readers/ReaderFactory.cs

@@ -33,7 +33,7 @@ namespace SharpCompress.Readers
                                  };
             RewindableStream rewindableStream = new RewindableStream(stream);
             rewindableStream.StartRecording();
-            if (ZipArchive.IsZipFile(rewindableStream, null))
+            if (ZipArchive.IsZipFile(rewindableStream, options.Password))
             {
                 rewindableStream.Rewind(true);
                 return ZipReader.Open(rewindableStream, options);

src/SharpCompress/Writers/Zip/ZipWriter.cs

@@ -19,10 +19,10 @@ namespace SharpCompress.Writers.Zip
     {
         private readonly CompressionType compressionType;
         private readonly CompressionLevel compressionLevel;
-        private readonly PpmdProperties ppmdProperties = new PpmdProperties(); // Caching properties to speed up PPMd
         private readonly List<ZipCentralDirectoryEntry> entries = new List<ZipCentralDirectoryEntry>();
         private readonly string zipComment;
         private long streamPosition;
+        private PpmdProperties ppmdProps;
 
         public ZipWriter(Stream destination, ZipWriterOptions zipWriterOptions)
             : base(ArchiveType.Zip)
@@ -34,6 +34,18 @@ namespace SharpCompress.Writers.Zip
             InitalizeStream(destination, !zipWriterOptions.LeaveStreamOpen);
         }
 
+        private PpmdProperties PpmdProperties
+        {
+            get
+            {
+                if (ppmdProps == null)
+                {
+                    ppmdProps = new PpmdProperties();
+                }
+                return ppmdProps;
+            }
+        }
+
         protected override void Dispose(bool isDisposing)
         {
             if (isDisposing)
@@ -252,8 +264,8 @@ namespace SharpCompress.Writers.Zip
                     }
                     case ZipCompressionMethod.PPMd:
                     {
-                        counting.Write(writer.ppmdProperties.Properties, 0, 2);
-                        return new PpmdStream(writer.ppmdProperties, counting, true);
+                        counting.Write(writer.PpmdProperties.Properties, 0, 2);
+                        return new PpmdStream(writer.PpmdProperties, counting, true);
                     }
                     default:
                     {

src/SharpCompress/project.json

@@ -1,5 +1,5 @@
 {
-    "version": "0.13.0",
+    "version": "0.13.1",
     "title": "SharpCompress - Pure C# Decompression/Compression",
     "authors": [ "Adam Hathcock" ],
     "language": "en-US",

test/SharpCompress.Test/Zip/ZipReaderTests.cs

@@ -228,6 +228,8 @@ namespace SharpCompress.Test
         [Fact]
         public void TestSharpCompressWithEmptyStream()
         {
+            ResetScratch();
+
             MemoryStream stream = new NonSeekableMemoryStream();
 
             using (IWriter zipWriter = WriterFactory.Open(stream, ArchiveType.Zip, CompressionType.Deflate))
@@ -250,7 +252,9 @@ namespace SharpCompress.Test
                         byte[] buf = new byte[bufSize];
                         int bytesRead = 0;
                         while ((bytesRead = entry.Read(buf, 0, bufSize)) > 0)
+                        {
                             tempStream.Write(buf, 0, bytesRead);
+                        }
                     }
                 }
             }