[PR #565] [CLOSED] On ongoing branch of making everything async #1102

New Issue

Open

opened 2026-01-29 22:19:00 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 22:19:00 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/565
Author: @adamhathcock
Created: 2/1/2021
Status: ❌ Closed

Base: master ← Head: async

---

📝 Commits (10+)

• 3a820c5 async Deflate. Start of writer
• bcdfd99 async dispose and fix tests?
• 2b4f029 more async await
• 9cf8a3d more awaits
• cdba5ec AsyncEnumerable usage in entries
• d234f2d First pass of trying tar
• 7d2dc58 More API fixes
• c6a011d Fixed reader issue
• 9738b81 Fix rewindable stream and encoding tests
• f40d334 Tar and Xz mostly work

📊 Changes

121 files changed (+3044 additions, -2920 deletions)

View changed files

📝 src/SharpCompress/Archives/AbstractArchive.cs (+46 -74)
📝 src/SharpCompress/Archives/AbstractWritableArchive.cs (+51 -45)
📝 src/SharpCompress/Archives/ArchiveFactory.cs (+31 -27)
📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+60 -49)
📝 src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs (+4 -2)
📝 src/SharpCompress/Archives/GZip/GZipWritableArchiveEntry.cs (+6 -4)
📝 src/SharpCompress/Archives/IArchive.cs (+10 -15)
📝 src/SharpCompress/Archives/IArchiveEntry.cs (+3 -1)
📝 src/SharpCompress/Archives/IArchiveEntryExtensions.cs (+22 -25)
📝 src/SharpCompress/Archives/IArchiveExtensions.cs (+8 -4)
➖ src/SharpCompress/Archives/IArchiveExtractionListener.cs (+0 -11)
📝 src/SharpCompress/Archives/IWritableArchive.cs (+6 -4)
📝 src/SharpCompress/Archives/IWritableArchiveExtensions.cs (+23 -18)
📝 src/SharpCompress/Archives/Tar/TarArchive.cs (+55 -48)
📝 src/SharpCompress/Archives/Tar/TarArchiveEntry.cs (+4 -2)
📝 src/SharpCompress/Archives/Tar/TarWritableArchiveEntry.cs (+6 -4)
📝 src/SharpCompress/Archives/Zip/ZipArchive.cs (+75 -54)
📝 src/SharpCompress/Archives/Zip/ZipArchiveEntry.cs (+4 -2)
📝 src/SharpCompress/Archives/Zip/ZipWritableArchiveEntry.cs (+6 -4)
➕ src/SharpCompress/AsyncEnumerable.cs (+25 -0)

...and 80 more files

📄 Description

• Use ReadAsync/WriteAsync on every stream
• Use CancelationToken (drop Listener interface?)
• Use ValueToken (need to find better Task.Completed version)
• Use IAsyncDisposable (drop IDispose as it mostly doesn't apply)
• Use IAsyncEnumerable
• Some usage of Memory/Span. Usage of MemoryPool seem good but don't want to completely convert yet.
• More?

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/565 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 2/1/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `async` --- ### 📝 Commits (10+) - [`3a820c5`](https://github.com/adamhathcock/sharpcompress/commit/3a820c52bd4136464ec03850e81fa382752df435) async Deflate. Start of writer - [`bcdfd99`](https://github.com/adamhathcock/sharpcompress/commit/bcdfd992a37cddde1613b29a7330ef8f82c07132) async dispose and fix tests? - [`2b4f029`](https://github.com/adamhathcock/sharpcompress/commit/2b4f02997ede997f94bdc74ca465e1dc33963d7f) more async await - [`9cf8a3d`](https://github.com/adamhathcock/sharpcompress/commit/9cf8a3dbbe97db981494d0a2cac709a969023e7a) more awaits - [`cdba5ec`](https://github.com/adamhathcock/sharpcompress/commit/cdba5ec4194ead2a238c57628ed3d19bf9c7d5c1) AsyncEnumerable usage in entries - [`d234f2d`](https://github.com/adamhathcock/sharpcompress/commit/d234f2d5095fbed0748e65f6cc705cf6cc31ab60) First pass of trying tar - [`7d2dc58`](https://github.com/adamhathcock/sharpcompress/commit/7d2dc58766f0e163129852ac9282f48cd33717fe) More API fixes - [`c6a011d`](https://github.com/adamhathcock/sharpcompress/commit/c6a011df178d2fc8bd6b28c0aee6e649c5247758) Fixed reader issue - [`9738b81`](https://github.com/adamhathcock/sharpcompress/commit/9738b812c4b355a53fbf7ac06217585a63ea20f0) Fix rewindable stream and encoding tests - [`f40d334`](https://github.com/adamhathcock/sharpcompress/commit/f40d3342c8145b7f7e201ed62001e31ef834a79c) Tar and Xz mostly work ### 📊 Changes **121 files changed** (+3044 additions, -2920 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/AbstractArchive.cs` (+46 -74) 📝 `src/SharpCompress/Archives/AbstractWritableArchive.cs` (+51 -45) 📝 `src/SharpCompress/Archives/ArchiveFactory.cs` (+31 -27) 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+60 -49) 📝 `src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs` (+4 -2) 📝 `src/SharpCompress/Archives/GZip/GZipWritableArchiveEntry.cs` (+6 -4) 📝 `src/SharpCompress/Archives/IArchive.cs` (+10 -15) 📝 `src/SharpCompress/Archives/IArchiveEntry.cs` (+3 -1) 📝 `src/SharpCompress/Archives/IArchiveEntryExtensions.cs` (+22 -25) 📝 `src/SharpCompress/Archives/IArchiveExtensions.cs` (+8 -4) ➖ `src/SharpCompress/Archives/IArchiveExtractionListener.cs` (+0 -11) 📝 `src/SharpCompress/Archives/IWritableArchive.cs` (+6 -4) 📝 `src/SharpCompress/Archives/IWritableArchiveExtensions.cs` (+23 -18) 📝 `src/SharpCompress/Archives/Tar/TarArchive.cs` (+55 -48) 📝 `src/SharpCompress/Archives/Tar/TarArchiveEntry.cs` (+4 -2) 📝 `src/SharpCompress/Archives/Tar/TarWritableArchiveEntry.cs` (+6 -4) 📝 `src/SharpCompress/Archives/Zip/ZipArchive.cs` (+75 -54) 📝 `src/SharpCompress/Archives/Zip/ZipArchiveEntry.cs` (+4 -2) 📝 `src/SharpCompress/Archives/Zip/ZipWritableArchiveEntry.cs` (+6 -4) ➕ `src/SharpCompress/AsyncEnumerable.cs` (+25 -0) _...and 80 more files_ </details> ### 📄 Description - Use ReadAsync/WriteAsync on every stream - Use CancelationToken (drop Listener interface?) - Use ValueToken (need to find better Task.Completed version) - Use IAsyncDisposable (drop IDispose as it mostly doesn't apply) - Use IAsyncEnumerable - Some usage of Memory/Span. Usage of MemoryPool seem good but don't want to completely convert yet. - More? --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 22:19:00 +00:00

claunia referenced this issue 2026-01-29 22:21:02 +00:00

[PR #1102] [MERGED] Add support for ACE archives #1537

claunia referenced this issue 2026-01-29 22:21:03 +00:00

[PR #1102] Add support for ACE archives #1540

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

copilot/fix-rar-extraction-issues

copilot/add-lzwreader-support

adam/add-alternate-compressions

adam/cleanup-options

copilot/fix-openentrystreamasync-memory-issue

release

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

0.44.5

0.44.4

0.44.3

0.44.2

0.44.1

0.44.0

0.43.0

0.42.1

0.42.0

0.41.0

0.40.0

0.39.0

0.38.0

0.37.2

0.37.1

0.37.0

0.36.0

0.35.0

0.34.2

0.34.1

0.34.0

0.33.0

0.32.2

0.32.1

0.32

0.31

0.30.1

0.30

0.29

0.29.0

0.28.3

0.28.2

0.28.1

0.28

0.27.1

0.27

0.26

0.25.1

0.25

0.24

0.23

0.22

0.21.1

0.21

0.21.0

0.20.0

0.19.2

0.19.1

0.19

0.18.2

0.18.1

0.18

0.17.1

0.17.0

0.16.2

0.16.1

0.16.0

0.15.2

0.15.1

0.15.0

0.14.1

0.14.0

0.13.1

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.6

0.11.5

0.11.4

0.11.3

0.11.2

0.11.1

0.11

0.10.3

0.10.2

0.10.1.3

0.10.1.2

0.10.1.1

0.10.1

0.10

0.9

Labels

Clear labels

bug

duplicate

enhancement

feedback requested

not bug

pull-request

Mirrored from GitHub Pull Request

question

up for grabs

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#1102