[PR #1102] [MERGED] Add support for ACE archives #1537

New Issue

Open

opened 2026-01-29 22:21:02 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 22:21:02 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1102
Author: @TwanVanDongen
Created: 1/3/2026
Status: ✅ Merged
Merged: 1/5/2026
Merged by: @adamhathcock

Base: master ← Head: master

---

📝 Commits (7)

• e1c8aa2 Add ACE archive support (read-only, stored entries)
• 909d36c more subtle check of magic bytes for ARJ archives
• 94adb77 Merge branch 'master' of https://github.com/TwanVanDongen/sharpcompress
• feece3d Missed some CSharpier edits
• bfcdeb3 Ace largefile test added
• 3ebf97d MultiVolume not supported, tests provided by split archive.
• 7a49eb9 Archives containing encrypted content throws exception.

📊 Changes

33 files changed (+1140 additions, -39 deletions)

View changed files

➕ src/SharpCompress/Common/Ace/AceCrc.cs (+61 -0)
➕ src/SharpCompress/Common/Ace/AceEntry.cs (+68 -0)
➕ src/SharpCompress/Common/Ace/AceFilePart.cs (+52 -0)
➕ src/SharpCompress/Common/Ace/AceVolume.cs (+35 -0)
➕ src/SharpCompress/Common/Ace/Headers/AceFileHeader.cs (+171 -0)
➕ src/SharpCompress/Common/Ace/Headers/AceHeader.cs (+153 -0)
➕ src/SharpCompress/Common/Ace/Headers/AceMainHeader.cs (+97 -0)
➕ src/SharpCompress/Common/Ace/Headers/CompressionQuality.cs (+16 -0)
➕ src/SharpCompress/Common/Ace/Headers/CompressionType.cs (+13 -0)
➕ src/SharpCompress/Common/Ace/Headers/HeaderFlags.cs (+33 -0)
➕ src/SharpCompress/Common/Ace/Headers/HostOS.cs (+22 -0)
📝 src/SharpCompress/Common/ArchiveType.cs (+1 -0)
📝 src/SharpCompress/Common/Arj/Headers/ArjHeader.cs (+19 -3)
📝 src/SharpCompress/Common/CompressionType.cs (+1 -0)
➕ src/SharpCompress/Factories/AceFactory.cs (+37 -0)
📝 src/SharpCompress/Factories/ArjFactory.cs (+1 -6)
📝 src/SharpCompress/Factories/Factory.cs (+1 -0)
➕ src/SharpCompress/Readers/Ace/AceReader.cs (+115 -0)
➕ src/SharpCompress/Readers/Ace/MultiVolumeAceReader.cs (+117 -0)
➕ src/SharpCompress/Readers/Ace/SingleVolumeAceReader.cs (+31 -0)

...and 13 more files

📄 Description

Initial implementation for reading ACE archives, stored only (for now).

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1102 **Author:** [@TwanVanDongen](https://github.com/TwanVanDongen) **Created:** 1/3/2026 **Status:** ✅ Merged **Merged:** 1/5/2026 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`e1c8aa2`](https://github.com/adamhathcock/sharpcompress/commit/e1c8aa226d7159d3281c3ffe0c624c91aad9110d) Add ACE archive support (read-only, stored entries) - [`909d36c`](https://github.com/adamhathcock/sharpcompress/commit/909d36c237771fba15f325d28835b27c0cdd915d) more subtle check of magic bytes for ARJ archives - [`94adb77`](https://github.com/adamhathcock/sharpcompress/commit/94adb77e9ee1294097c3d842e34125a30fae7e1f) Merge branch 'master' of https://github.com/TwanVanDongen/sharpcompress - [`feece3d`](https://github.com/adamhathcock/sharpcompress/commit/feece3d788e91a51c95344e76bad50083ba20405) Missed some CSharpier edits - [`bfcdeb3`](https://github.com/adamhathcock/sharpcompress/commit/bfcdeb3784cef44f6e12f6ce58312601c3857455) Ace largefile test added - [`3ebf97d`](https://github.com/adamhathcock/sharpcompress/commit/3ebf97dd4990a770c9bebae98f24d67f71cdaaf0) MultiVolume not supported, tests provided by split archive. - [`7a49eb9`](https://github.com/adamhathcock/sharpcompress/commit/7a49eb9e93daa1e2f9898804a7d6637c6b42b328) Archives containing encrypted content throws exception. ### 📊 Changes **33 files changed** (+1140 additions, -39 deletions) <details> <summary>View changed files</summary> ➕ `src/SharpCompress/Common/Ace/AceCrc.cs` (+61 -0) ➕ `src/SharpCompress/Common/Ace/AceEntry.cs` (+68 -0) ➕ `src/SharpCompress/Common/Ace/AceFilePart.cs` (+52 -0) ➕ `src/SharpCompress/Common/Ace/AceVolume.cs` (+35 -0) ➕ `src/SharpCompress/Common/Ace/Headers/AceFileHeader.cs` (+171 -0) ➕ `src/SharpCompress/Common/Ace/Headers/AceHeader.cs` (+153 -0) ➕ `src/SharpCompress/Common/Ace/Headers/AceMainHeader.cs` (+97 -0) ➕ `src/SharpCompress/Common/Ace/Headers/CompressionQuality.cs` (+16 -0) ➕ `src/SharpCompress/Common/Ace/Headers/CompressionType.cs` (+13 -0) ➕ `src/SharpCompress/Common/Ace/Headers/HeaderFlags.cs` (+33 -0) ➕ `src/SharpCompress/Common/Ace/Headers/HostOS.cs` (+22 -0) 📝 `src/SharpCompress/Common/ArchiveType.cs` (+1 -0) 📝 `src/SharpCompress/Common/Arj/Headers/ArjHeader.cs` (+19 -3) 📝 `src/SharpCompress/Common/CompressionType.cs` (+1 -0) ➕ `src/SharpCompress/Factories/AceFactory.cs` (+37 -0) 📝 `src/SharpCompress/Factories/ArjFactory.cs` (+1 -6) 📝 `src/SharpCompress/Factories/Factory.cs` (+1 -0) ➕ `src/SharpCompress/Readers/Ace/AceReader.cs` (+115 -0) ➕ `src/SharpCompress/Readers/Ace/MultiVolumeAceReader.cs` (+117 -0) ➕ `src/SharpCompress/Readers/Ace/SingleVolumeAceReader.cs` (+31 -0) _...and 13 more files_ </details> ### 📄 Description Initial implementation for reading ACE archives, stored only (for now). --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 22:21:02 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

release

adam/merge-release-to-master

dependabot/nuget/xunit.v3-3.2.2

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

0.44.5

0.44.4

0.44.3

0.44.2

0.44.1

0.44.0

0.43.0

0.42.1

0.42.0

0.41.0

0.40.0

0.39.0

0.38.0

0.37.2

0.37.1

0.37.0

0.36.0

0.35.0

0.34.2

0.34.1

0.34.0

0.33.0

0.32.2

0.32.1

0.32

0.31

0.30.1

0.30

0.29

0.29.0

0.28.3

0.28.2

0.28.1

0.28

0.27.1

0.27

0.26

0.25.1

0.25

0.24

0.23

0.22

0.21.1

0.21

0.21.0

0.20.0

0.19.2

0.19.1

0.19

0.18.2

0.18.1

0.18

0.17.1

0.17.0

0.16.2

0.16.1

0.16.0

0.15.2

0.15.1

0.15.0

0.14.1

0.14.0

0.13.1

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.6

0.11.5

0.11.4

0.11.3

0.11.2

0.11.1

0.11

0.10.3

0.10.2

0.10.1.3

0.10.1.2

0.10.1.1

0.10.1

0.10

0.9

Labels

Clear labels

bug

duplicate

enhancement

feedback requested

not bug

pull-request

Mirrored from GitHub Pull Request

question

up for grabs

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#1537