starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-08 13:34:57 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #675] [MERGED] ReadOnlySubStream overrides and adds logic #636 #1158

New Issue
Closed
opened 2026-01-29 22:19:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/675
Author: @Erior
Created: 6/21/2022
Status: ✅ Merged
Merged: 6/22/2022
Merged by: @adamhathcock

Base: master ← Head: feature/#636

📝 Commits (2)

  • 089b163 ReadOnlySubStream overrides and adds logic to Read byte[], needs to have same logic for Span for consistency.
  • 8cb566b Merge branch 'master' into feature/#636

📊 Changes

2 files changed (+37 additions, -2 deletions)

View changed files

📝 src/SharpCompress/IO/ReadOnlySubStream.cs (+15 -2)
📝 tests/SharpCompress.Test/Zip/ZipArchiveTests.cs (+22 -0)

📄 Description

ReadOnlySubStream overrides and adds logic to Read byte[], it needs to have same logic for Span for consistency.
#636

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/675 **Author:** [@Erior](https://github.com/Erior) **Created:** 6/21/2022 **Status:** ✅ Merged **Merged:** 6/22/2022 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/#636` --- ### 📝 Commits (2) - [`089b163`](https://github.com/adamhathcock/sharpcompress/commit/089b16326e9202e644fcfe0a85a2752e19769c10) ReadOnlySubStream overrides and adds logic to Read byte[], needs to have same logic for Span<byte> for consistency. - [`8cb566b`](https://github.com/adamhathcock/sharpcompress/commit/8cb566b031bd4a0028238a879ccf0e572a3240af) Merge branch 'master' into feature/#636 ### 📊 Changes **2 files changed** (+37 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/IO/ReadOnlySubStream.cs` (+15 -2) 📝 `tests/SharpCompress.Test/Zip/ZipArchiveTests.cs` (+22 -0) </details> ### 📄 Description ReadOnlySubStream overrides and adds logic to Read byte[], it needs to have same logic for Span<byte> for consistency. #636 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1158
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?