starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Problem with Microsoft.SourceLink.GitHub dependency #636

New Issue
Closed
opened 2026-01-29 22:15:04 +00:00 by claunia · 10 comments
claunia commented 2026-01-29 22:15:04 +00:00
Owner
Copy Link

Originally created by @bdovaz on GitHub (Apr 26, 2024).

It must be added as PrivateAssets=“All”. I use the Avalonia repository as an example:

76a1c70758/build/SourceLink.props (L18)

As it stands since version 0.37.0 it has a dependency that propagates to consumers of the package when it should not:

https://www.nuget.org/packages/SharpCompress/0.37.0#dependencies-body-tab

Originally created by @bdovaz on GitHub (Apr 26, 2024). It must be added as `PrivateAssets=“All”`. I use the Avalonia repository as an example: https://github.com/AvaloniaUI/Avalonia/blob/76a1c70758884abcebc9e3665aa08290a841efa4/build/SourceLink.props#L18 As it stands since version 0.37.0 it has a dependency that propagates to consumers of the package when it should not: https://www.nuget.org/packages/SharpCompress/0.37.0#dependencies-body-tab
claunia added the bug label 2026-01-29 22:15:04 +00:00
claunia commented 2026-01-29 22:15:04 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Apr 27, 2024):

I never looked that up to see what it did.

I've made the change here: 1393629bc5

Thanks for the heads up

@adamhathcock commented on GitHub (Apr 27, 2024): I never looked that up to see what it did. I've made the change here: https://github.com/adamhathcock/sharpcompress/commit/1393629bc5db0b806c7033a062670a5bb7a4ae80 Thanks for the heads up
claunia commented 2026-01-29 22:15:05 +00:00
Author
Owner
Copy Link

@bdovaz commented on GitHub (Apr 27, 2024):

Can you release it on nuget please? We use this package in Unity and it causes us problems.

Thanks for your help!

@bdovaz commented on GitHub (Apr 27, 2024): Can you release it on nuget please? We use this package in Unity and it causes us problems. Thanks for your help!
claunia commented 2026-01-29 22:15:05 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Apr 27, 2024):

Not sure it achieved what you wanted: https://www.nuget.org/packages/SharpCompress/0.37.1

@adamhathcock commented on GitHub (Apr 27, 2024): Not sure it achieved what you wanted: https://www.nuget.org/packages/SharpCompress/0.37.1
claunia commented 2026-01-29 22:15:05 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Apr 27, 2024):

real real fix: 446852c7d0

The tests no longer reference this package

@adamhathcock commented on GitHub (Apr 27, 2024): real real fix: https://github.com/adamhathcock/sharpcompress/commit/446852c7d0796e7ce375ebf136a05bbda47ee237 The tests no longer reference this package
claunia commented 2026-01-29 22:15:06 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Apr 27, 2024):

https://www.nuget.org/packages/SharpCompress/0.37.2

@adamhathcock commented on GitHub (Apr 27, 2024): https://www.nuget.org/packages/SharpCompress/0.37.2
claunia commented 2026-01-29 22:15:06 +00:00
Author
Owner
Copy Link

@bdovaz commented on GitHub (Apr 27, 2024):

Thank you @adamhathcock for your quick response and release!

@bdovaz commented on GitHub (Apr 27, 2024): Thank you @adamhathcock for your quick response and release!
claunia commented 2026-01-29 22:15:06 +00:00
Author
Owner
Copy Link

@bdovaz commented on GitHub (Apr 27, 2024):

@adamhathcock can you unlist on NuGet 0.37.0 and 0.37.1? Thanks!

So that no one consumes these versions with incorrect dependencies

https://learn.microsoft.com/en-us/nuget/nuget-org/policies/deleting-packages#unlisting-a-package

@bdovaz commented on GitHub (Apr 27, 2024): @adamhathcock can you unlist on NuGet 0.37.0 and 0.37.1? Thanks! So that no one consumes these versions with incorrect dependencies https://learn.microsoft.com/en-us/nuget/nuget-org/policies/deleting-packages#unlisting-a-package
claunia commented 2026-01-29 22:15:06 +00:00
Author
Owner
Copy Link

@bdovaz commented on GitHub (Apr 29, 2024):

@adamhathcock can you please hide those 2 versions with the instructions I gave you? It's giving us problems at: https://github.com/xoofx/UnityNuGet

We can't resolve in Unity those incorrect dependencies.

Thank you.

@bdovaz commented on GitHub (Apr 29, 2024): @adamhathcock can you please hide those 2 versions with the instructions I gave you? It's giving us problems at: https://github.com/xoofx/UnityNuGet We can't resolve in Unity those incorrect dependencies. Thank you.
claunia commented 2026-01-29 22:15:07 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Apr 29, 2024):

unlisted

@adamhathcock commented on GitHub (Apr 29, 2024): unlisted
claunia commented 2026-01-29 22:15:07 +00:00
Author
Owner
Copy Link

@bdovaz commented on GitHub (Apr 29, 2024):

Thank you!

@bdovaz commented on GitHub (Apr 29, 2024): Thank you!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#636
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?