starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-10 21:22:11 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #805] [MERGED] Zip: Use last modified time from basic header when validating zip decryption #1243

New Issue
Open
opened 2026-01-29 22:19:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/805
Author: @DannyBoyk
Created: 1/26/2024
Status: ✅ Merged
Merged: 1/29/2024
Merged by: @adamhathcock

Base: master ← Head: 804_Fix_ZIP_Decryption

📝 Commits (1)

  • 14c9735 Zip: Use last modified time from basic header when validating zip decryption

📊 Changes

4 files changed (+23 additions, -5 deletions)

View changed files

📝 src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs (+2 -2)
📝 src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs (+2 -2)
📝 src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs (+18 -0)
📝 src/SharpCompress/Common/Zip/PkwareTraditionalEncryptionData.cs (+1 -1)

📄 Description

The last modified time used for zip decryption validation must be the one from the basic header. If UnixTimeExtraFields are present, the previous implementation was attempting to verify against that value instead.
Fixed #804

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/805 **Author:** [@DannyBoyk](https://github.com/DannyBoyk) **Created:** 1/26/2024 **Status:** ✅ Merged **Merged:** 1/29/2024 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `804_Fix_ZIP_Decryption` --- ### 📝 Commits (1) - [`14c9735`](https://github.com/adamhathcock/sharpcompress/commit/14c973558b975d6288788fe53882517283b5a4ec) Zip: Use last modified time from basic header when validating zip decryption ### 📊 Changes **4 files changed** (+23 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs` (+2 -2) 📝 `src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs` (+2 -2) 📝 `src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs` (+18 -0) 📝 `src/SharpCompress/Common/Zip/PkwareTraditionalEncryptionData.cs` (+1 -1) </details> ### 📄 Description The last modified time used for zip decryption validation must be the one from the basic header. If UnixTimeExtraFields are present, the previous implementation was attempting to verify against that value instead. Fixed #804 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?