starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #44] Added IWritableArchive interface #804

New Issue
Open
opened 2026-01-29 22:17:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:17:39 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/44

State: closed
Merged: Yes

So that when working with ArchiveFactory, you can cast the opened
archive to IWritableArchive for accessing AddEntry, RemoveEntry and
SaveTo methods without having to know what type of archive is opened
underhood. Also moved extension methods from AbstractWritableArchive to
this new interface. Also added GZipArchive to ArchiveFactory.Create as
it is one of the 3 writable archive types (zip, tar, gzip), not sure why
it was omitted.

Also replaced NotImplementedException for streams.
Especially for streams, it is more appropriate to throw
NotSupportedException instead of NotImplementedException. Usually
consumers of streams expect NotSupportedException to handle errors.
For reference about this best practice, please see
these articles:
http://blogs.msdn.com/b/brada/archive/2004/07/29/201354.aspx
http://blogs.msdn.com/b/jaredpar/archive/2008/12/12/notimplementedexception-vs-notsupportedexception.aspx

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/44 **State:** closed **Merged:** Yes --- So that when working with ArchiveFactory, you can cast the opened archive to IWritableArchive for accessing AddEntry, RemoveEntry and SaveTo methods without having to know what type of archive is opened underhood. Also moved extension methods from AbstractWritableArchive to this new interface. Also added GZipArchive to ArchiveFactory.Create as it is one of the 3 writable archive types (zip, tar, gzip), not sure why it was omitted. Also replaced NotImplementedException for streams. Especially for streams, it is more appropriate to throw NotSupportedException instead of NotImplementedException. Usually consumers of streams expect NotSupportedException to handle errors. For reference about this best practice, please see these articles: http://blogs.msdn.com/b/brada/archive/2004/07/29/201354.aspx http://blogs.msdn.com/b/jaredpar/archive/2008/12/12/notimplementedexception-vs-notsupportedexception.aspx
claunia added the pull-request label 2026-01-29 22:17:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#804
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?