mirror of
https://github.com/adamhathcock/sharpcompress.git
synced 2026-02-03 21:23:38 +00:00
Allow Getting of Position of Stream #44
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @thegreatco on GitHub (Jul 20, 2015).
Retrieval of the position of either the current stream (eg, number of bytes already read) or the underlying compressed stream would be helpful when trying to determine read rates for display.
I am fine with just getting the current position of the underlying stream and not the number of inflated bytes, but I suspect both are equally easy to expose.
@adamhathcock commented on GitHub (Jul 20, 2015):
A lot of streams are forward-only and don't have a position (e.g. network stream). If you want to have to display something, you could count it yourself.
A lot of this library was with decompressing on the fly from gigabyte files or network streams where random seeking isn't possible. I could expose a position but then it would throw exceptions in a lot of cases.
@weltkante commented on GitHub (Sep 9, 2015):
@thegreatco While that would be useful it would break the stream contract which says that the position property is reserved for seekable streams. You aren't supposed to access the position for nonseekable streams.
If it is done anyways it should be implemented as new properties on the SharpCompress streams and not by overriding the Position property for something it isn't supposed to do.
(PS: The standard thing you do if you need "on the fly" positions is wrapping either the input or output streams in a custom stream subclass and do the counting yourself. That gives you easy hooks for when the writes/reads happen, allowing you to update your progress and having minimum performance overhead.)