[PR #834] [MERGED] Add SharpCompressException and use it or children in most places #1270

New Issue

Open

opened 2026-01-29 22:19:44 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 22:19:44 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/834
Author: @adamhathcock
Created: 4/23/2024
Status: ✅ Merged
Merged: 4/28/2025
Merged by: @adamhathcock

Base: master ← Head: exception-normalization

---

📝 Commits (9)

• 8cb621e Add SharpCompressException and use it or children in most places
• a283d99 compiles
• e31238d fmt
• e4d5b56 fix more nulls and tests
• 5d9c995 fmt
• 95caffe Merge remote-tracking branch 'origin/master' into exception-normalization
• d3a9e34 Merge fixes
• a480a88 format
• 1f39a0c Merge remote-tracking branch 'origin/master' into exception-normalization

📊 Changes

70 files changed (+234 additions, -258 deletions)

View changed files

📝 src/SharpCompress/Archives/AbstractArchive.cs (+1 -1)
📝 src/SharpCompress/Archives/AbstractWritableArchive.cs (+1 -1)
📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+2 -2)
📝 src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs (+1 -1)
📝 src/SharpCompress/Archives/Rar/RarArchiveEntry.cs (+1 -1)
📝 src/SharpCompress/Archives/Tar/TarArchiveEntry.cs (+1 -1)
📝 src/SharpCompress/Archives/Zip/ZipArchiveEntry.cs (+1 -1)
➖ src/SharpCompress/Common/ArchiveException.cs (+0 -9)
➖ src/SharpCompress/Common/CryptographicException.cs (+0 -9)
➖ src/SharpCompress/Common/ExtractionException.cs (+0 -12)
📝 src/SharpCompress/Common/FilePart.cs (+1 -1)
➖ src/SharpCompress/Common/IncompleteArchiveException.cs (+0 -7)
➖ src/SharpCompress/Common/InvalidFormatException.cs (+0 -12)
➖ src/SharpCompress/Common/MultiVolumeExtractionException.cs (+0 -12)
➖ src/SharpCompress/Common/MultipartStreamRequiredException.cs (+0 -7)
📝 src/SharpCompress/Common/Rar/CryptKey5.cs (+1 -1)
📝 src/SharpCompress/Common/Rar/Headers/ArchiveCryptHeader.cs (+0 -3)
📝 src/SharpCompress/Common/Rar/Headers/FileHeader.cs (+29 -20)
📝 src/SharpCompress/Common/Rar/Headers/RarHeader.cs (+1 -2)
📝 src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs (+8 -5)

...and 50 more files

📄 Description

covers https://github.com/adamhathcock/sharpcompress/issues/830

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/834 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 4/23/2024 **Status:** ✅ Merged **Merged:** 4/28/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `exception-normalization` --- ### 📝 Commits (9) - [`8cb621e`](https://github.com/adamhathcock/sharpcompress/commit/8cb621ebed2557916840049c652ccccdbd31a37a) Add SharpCompressException and use it or children in most places - [`a283d99`](https://github.com/adamhathcock/sharpcompress/commit/a283d99e1b833ea2ea8181779593fe17d021fbd3) compiles - [`e31238d`](https://github.com/adamhathcock/sharpcompress/commit/e31238d12134b8efa75046f9090cad56b0717709) fmt - [`e4d5b56`](https://github.com/adamhathcock/sharpcompress/commit/e4d5b56951e66a1e7d3bbe95b74eb64e329e8595) fix more nulls and tests - [`5d9c995`](https://github.com/adamhathcock/sharpcompress/commit/5d9c99508dd9406c738de01a1ae15d329de6ff6e) fmt - [`95caffe`](https://github.com/adamhathcock/sharpcompress/commit/95caffe607ac606c945f976690afbc770b9f1f3b) Merge remote-tracking branch 'origin/master' into exception-normalization - [`d3a9e34`](https://github.com/adamhathcock/sharpcompress/commit/d3a9e341a5a7b8bba9c9a837fae83223a615e8b0) Merge fixes - [`a480a88`](https://github.com/adamhathcock/sharpcompress/commit/a480a8893c851f88cdf04666561f797f85e9a677) format - [`1f39a0c`](https://github.com/adamhathcock/sharpcompress/commit/1f39a0c9da5557a6d0fbe54c93ec8089fd16af53) Merge remote-tracking branch 'origin/master' into exception-normalization ### 📊 Changes **70 files changed** (+234 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/AbstractArchive.cs` (+1 -1) 📝 `src/SharpCompress/Archives/AbstractWritableArchive.cs` (+1 -1) 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+2 -2) 📝 `src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Rar/RarArchiveEntry.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Tar/TarArchiveEntry.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Zip/ZipArchiveEntry.cs` (+1 -1) ➖ `src/SharpCompress/Common/ArchiveException.cs` (+0 -9) ➖ `src/SharpCompress/Common/CryptographicException.cs` (+0 -9) ➖ `src/SharpCompress/Common/ExtractionException.cs` (+0 -12) 📝 `src/SharpCompress/Common/FilePart.cs` (+1 -1) ➖ `src/SharpCompress/Common/IncompleteArchiveException.cs` (+0 -7) ➖ `src/SharpCompress/Common/InvalidFormatException.cs` (+0 -12) ➖ `src/SharpCompress/Common/MultiVolumeExtractionException.cs` (+0 -12) ➖ `src/SharpCompress/Common/MultipartStreamRequiredException.cs` (+0 -7) 📝 `src/SharpCompress/Common/Rar/CryptKey5.cs` (+1 -1) 📝 `src/SharpCompress/Common/Rar/Headers/ArchiveCryptHeader.cs` (+0 -3) 📝 `src/SharpCompress/Common/Rar/Headers/FileHeader.cs` (+29 -20) 📝 `src/SharpCompress/Common/Rar/Headers/RarHeader.cs` (+1 -2) 📝 `src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs` (+8 -5) _...and 50 more files_ </details> ### 📄 Description covers https://github.com/adamhathcock/sharpcompress/issues/830 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 22:19:44 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

copilot/fix-rar-extraction-issues

copilot/add-lzwreader-support

adam/add-alternate-compressions

adam/cleanup-options

copilot/fix-openentrystreamasync-memory-issue

release

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

0.44.5

0.44.4

0.44.3

0.44.2

0.44.1

0.44.0

0.43.0

0.42.1

0.42.0

0.41.0

0.40.0

0.39.0

0.38.0

0.37.2

0.37.1

0.37.0

0.36.0

0.35.0

0.34.2

0.34.1

0.34.0

0.33.0

0.32.2

0.32.1

0.32

0.31

0.30.1

0.30

0.29

0.29.0

0.28.3

0.28.2

0.28.1

0.28

0.27.1

0.27

0.26

0.25.1

0.25

0.24

0.23

0.22

0.21.1

0.21

0.21.0

0.20.0

0.19.2

0.19.1

0.19

0.18.2

0.18.1

0.18

0.17.1

0.17.0

0.16.2

0.16.1

0.16.0

0.15.2

0.15.1

0.15.0

0.14.1

0.14.0

0.13.1

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.6

0.11.5

0.11.4

0.11.3

0.11.2

0.11.1

0.11

0.10.3

0.10.2

0.10.1.3

0.10.1.2

0.10.1.1

0.10.1

0.10

0.9

Labels

Clear labels

bug

duplicate

enhancement

feedback requested

not bug

pull-request

Mirrored from GitHub Pull Request

question

up for grabs

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#1270