starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-08 13:34:57 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #101] [MERGED] Non-compilable statements + zip archive handling #834

New Issue
Open
opened 2026-01-29 22:17:48 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:17:48 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/101
Author: @fracrtio
Created: 11/19/2015
Status: ✅ Merged
Merged: 11/19/2015
Merged by: @adamhathcock

Base: master ← Head: master

📝 Commits (3)

  • 13bbb20 Changed MAX_ITERATIONS_FOR_DIRECTORY_HEADER to deal with archives that have larger comments
  • 18bd810 Fixed non-compilable statements
  • 0f12a07 Eliminated "throw - catch all" logic in ZipArchive

📊 Changes

5 files changed (+19 additions, -18 deletions)

View changed files

📝 SharpCompress/Archive/Zip/ZipArchive.cs (+1 -1)
📝 SharpCompress/Common/Zip/SeekableZipHeaderFactory.cs (+1 -1)
📝 SharpCompress/Common/Zip/StreamingZipHeaderFactory.cs (+10 -11)
📝 SharpCompress/Common/Zip/ZipHeaderFactory.cs (+1 -1)
📝 SharpCompress/Compressor/Deflate/DeflateManager.cs (+6 -4)

📄 Description

  • Fixed non-compilable statements in DelfateManager
  • Eliminated "throw - catch all" logic in ZipArchive (performance issue)
  • ZipArchive with comments handling

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/101 **Author:** [@fracrtio](https://github.com/fracrtio) **Created:** 11/19/2015 **Status:** ✅ Merged **Merged:** 11/19/2015 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`13bbb20`](https://github.com/adamhathcock/sharpcompress/commit/13bbb202c7a58a4f8139b0d9fd6babe667618ba7) Changed MAX_ITERATIONS_FOR_DIRECTORY_HEADER to deal with archives that have larger comments - [`18bd810`](https://github.com/adamhathcock/sharpcompress/commit/18bd8102281c04c7eb09ecfdd984d7382b629f2c) Fixed non-compilable statements - [`0f12a07`](https://github.com/adamhathcock/sharpcompress/commit/0f12a073af4486509dfd777da1854efb5dc571ee) Eliminated "throw - catch all" logic in ZipArchive ### 📊 Changes **5 files changed** (+19 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `SharpCompress/Archive/Zip/ZipArchive.cs` (+1 -1) 📝 `SharpCompress/Common/Zip/SeekableZipHeaderFactory.cs` (+1 -1) 📝 `SharpCompress/Common/Zip/StreamingZipHeaderFactory.cs` (+10 -11) 📝 `SharpCompress/Common/Zip/ZipHeaderFactory.cs` (+1 -1) 📝 `SharpCompress/Compressor/Deflate/DeflateManager.cs` (+6 -4) </details> ### 📄 Description - Fixed non-compilable statements in DelfateManager - Eliminated "throw - catch all" logic in ZipArchive (performance issue) - ZipArchive with comments handling --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:17:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#834
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?