starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-09 21:24:08 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #933] [MERGED] Implement Attrib for ZipEntry #1354

New Issue
Open
opened 2026-01-29 22:20:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:09 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/933
Author: @Morilli
Created: 7/22/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @adamhathcock

Base: master ← Head: zipentry-attribute

📝 Commits (2)

📊 Changes

6 files changed (+16 additions, -2 deletions)

View changed files

📝 src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs (+0 -2)
📝 src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs (+2 -0)
📝 src/SharpCompress/Common/Zip/SeekableZipHeaderFactory.cs (+1 -0)
📝 src/SharpCompress/Common/Zip/ZipEntry.cs (+2 -0)
📝 tests/SharpCompress.Test/Zip/ZipArchiveTests.cs (+11 -0)
➕ tests/TestArchives/Archives/Zip.644.zip (+0 -0)

📄 Description

As mentioned in #926 this was throwing a NotImplementedException.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/933 **Author:** [@Morilli](https://github.com/Morilli) **Created:** 7/22/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `zipentry-attribute` --- ### 📝 Commits (2) - [`5e72ce5`](https://github.com/adamhathcock/sharpcompress/commit/5e72ce5fbe595be4197c9c2d9eb717700cff212c) add failing test - [`015dfa4`](https://github.com/adamhathcock/sharpcompress/commit/015dfa41b19b1c6e97be48a831e7ab395190da17) implement `Attrib` for ZipEntrys ### 📊 Changes **6 files changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs` (+0 -2) 📝 `src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs` (+2 -0) 📝 `src/SharpCompress/Common/Zip/SeekableZipHeaderFactory.cs` (+1 -0) 📝 `src/SharpCompress/Common/Zip/ZipEntry.cs` (+2 -0) 📝 `tests/SharpCompress.Test/Zip/ZipArchiveTests.cs` (+11 -0) ➕ `tests/TestArchives/Archives/Zip.644.zip` (+0 -0) </details> ### 📄 Description As mentioned in #926 this was throwing a `NotImplementedException`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:20:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1354
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?