starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #245] [MERGED] Lzip #926

New Issue
Open
opened 2026-01-29 22:18:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:14 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/245
Author: @adamhathcock
Created: 5/30/2017
Status: ✅ Merged
Merged: 5/31/2017
Merged by: @adamhathcock

Base: master ← Head: lzip

📝 Commits (10+)

  • f09b31e First pass. Writing isn't implemented on stream. Tests are busted.
  • b879449 LZipReader works...no file name :(
  • f85ae05 LZipWriter works
  • 7984b32 Writing tests are actually correct now. LZipStream correctly writes trailer now. lzip command line tool likes it.
  • e1b121b Add recommendation blurb
  • b2863a4 Update notes for formats
  • 9e6b5cb Merge branch 'master' into lzip
  • 2952bdd LZip isn't an archive format
  • 42ca995 Attempting to fix and implement crc32
  • 10cc8fd LZip writing test passes

📊 Changes

16 files changed (+274 additions, -56 deletions)

View changed files

📝 FORMATS.md (+20 -2)
📝 README.md (+10 -0)
📝 src/SharpCompress/Archives/ArchiveFactory.cs (+2 -1)
📝 src/SharpCompress/Compressors/Deflate/CRC32.cs (+3 -3)
📝 src/SharpCompress/Compressors/LZMA/LZipStream.cs (+75 -28)
📝 src/SharpCompress/Compressors/LZMA/LzmaStream.cs (+1 -4)
➕ src/SharpCompress/Crypto/Crc32Stream.cs (+106 -0)
📝 src/SharpCompress/IO/CountingWritableSubStream.cs (+1 -0)
📝 src/SharpCompress/Readers/ReaderFactory.cs (+1 -1)
📝 src/SharpCompress/SharpCompress.csproj (+0 -3)
📝 src/SharpCompress/Writers/Tar/TarWriter.cs (+22 -4)
📝 tests/SharpCompress.Test/ADCTest.cs (+26 -0)
📝 tests/SharpCompress.Test/SharpCompress.Test.csproj (+1 -6)
📝 tests/SharpCompress.Test/Tar/TarWriterTests.cs (+6 -0)
📝 tests/SharpCompress.Test/WriterTests.cs (+0 -4)
➕ tests/TestArchives/Archives/Tar.noEmptyDirs.tar.lz (+0 -0)

📄 Description

Covers https://github.com/adamhathcock/sharpcompress/issues/241

No CRC validation or writing. Maybe is a problem. Need to test with other applications

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/245 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 5/30/2017 **Status:** ✅ Merged **Merged:** 5/31/2017 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `lzip` --- ### 📝 Commits (10+) - [`f09b31e`](https://github.com/adamhathcock/sharpcompress/commit/f09b31e485e4fcece5e7c1ec2e78588f83013c7d) First pass. Writing isn't implemented on stream. Tests are busted. - [`b879449`](https://github.com/adamhathcock/sharpcompress/commit/b879449caf4c4e485cf4e999116b4329ebb11d6f) LZipReader works...no file name :( - [`f85ae05`](https://github.com/adamhathcock/sharpcompress/commit/f85ae0567136f3dec629d7b0584959224b347438) LZipWriter works - [`7984b32`](https://github.com/adamhathcock/sharpcompress/commit/7984b321ba810402225d6a3f31485ef1dcc7ab10) Writing tests are actually correct now. LZipStream correctly writes trailer now. lzip command line tool likes it. - [`e1b121b`](https://github.com/adamhathcock/sharpcompress/commit/e1b121b177ac3f521e576d72a5e33c9b78deb7fb) Add recommendation blurb - [`b2863a4`](https://github.com/adamhathcock/sharpcompress/commit/b2863a42babc5c46e990ea2c50b270877500b580) Update notes for formats - [`9e6b5cb`](https://github.com/adamhathcock/sharpcompress/commit/9e6b5cb6917e5f0478561b6f90343bfe06205ffa) Merge branch 'master' into lzip - [`2952bdd`](https://github.com/adamhathcock/sharpcompress/commit/2952bdda35400a57c923651acab1322f2095f6e1) LZip isn't an archive format - [`42ca995`](https://github.com/adamhathcock/sharpcompress/commit/42ca995d76a7486ae9645d7f4c9a98f7e18b72b3) Attempting to fix and implement crc32 - [`10cc8fd`](https://github.com/adamhathcock/sharpcompress/commit/10cc8fdeeed1b183cb0eaf2619ad2d19f222f0fd) LZip writing test passes ### 📊 Changes **16 files changed** (+274 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `FORMATS.md` (+20 -2) 📝 `README.md` (+10 -0) 📝 `src/SharpCompress/Archives/ArchiveFactory.cs` (+2 -1) 📝 `src/SharpCompress/Compressors/Deflate/CRC32.cs` (+3 -3) 📝 `src/SharpCompress/Compressors/LZMA/LZipStream.cs` (+75 -28) 📝 `src/SharpCompress/Compressors/LZMA/LzmaStream.cs` (+1 -4) ➕ `src/SharpCompress/Crypto/Crc32Stream.cs` (+106 -0) 📝 `src/SharpCompress/IO/CountingWritableSubStream.cs` (+1 -0) 📝 `src/SharpCompress/Readers/ReaderFactory.cs` (+1 -1) 📝 `src/SharpCompress/SharpCompress.csproj` (+0 -3) 📝 `src/SharpCompress/Writers/Tar/TarWriter.cs` (+22 -4) 📝 `tests/SharpCompress.Test/ADCTest.cs` (+26 -0) 📝 `tests/SharpCompress.Test/SharpCompress.Test.csproj` (+1 -6) 📝 `tests/SharpCompress.Test/Tar/TarWriterTests.cs` (+6 -0) 📝 `tests/SharpCompress.Test/WriterTests.cs` (+0 -4) ➕ `tests/TestArchives/Archives/Tar.noEmptyDirs.tar.lz` (+0 -0) </details> ### 📄 Description Covers https://github.com/adamhathcock/sharpcompress/issues/241 No CRC validation or writing. Maybe is a problem. Need to test with other applications --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#926
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?