starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Cannot call ZipArchiveEntry.OpenEntryStream() multiple times with WinZipAes encrypted ZIP file #174

New Issue
Closed
opened 2026-01-29 22:07:46 +00:00 by claunia · 5 comments
claunia commented 2026-01-29 22:07:46 +00:00
Owner
Copy Link

Originally created by @dbaumber on GitHub (May 18, 2017).

When debugging an issue with not being able to open a stream to an entry in WinZipAes protected ZIP file, I found that if ZipArchiveEntry.OpenEntryStream() is called a second time, SharpCompress throws a CryptographicException with a message "The password did not match", which is thrown from PkwareTraditionalEncryptionData.ForRead(). More analysis shows that Header.CompressionMethod is changed from WinZipAes (correct value) to Deflate (wrong value) after GetCompressedStream() is called in ZipArchiveEntry.OpenEntryStream(). When OpenEntryStream() is called again, it thinks it is encrypted with PKWARE traditional encryption rather than WinZipAes, which fails.

I made a change to ZipArchiveEntry.OpenEntryStream() to save and restore the compression method which resolves this issue. I can provide this as a patch. This behavior has changed since 0.11, the previous version we used. OpenEntryStream() should be able to be called more than once since it returns a non-seekable stream, this allows for resetting the stream for a file entry back to the beginning of the entry.

Originally created by @dbaumber on GitHub (May 18, 2017). When debugging an issue with not being able to open a stream to an entry in WinZipAes protected ZIP file, I found that if ZipArchiveEntry.OpenEntryStream() is called a second time, SharpCompress throws a CryptographicException with a message "The password did not match", which is thrown from PkwareTraditionalEncryptionData.ForRead(). More analysis shows that Header.CompressionMethod is changed from WinZipAes (correct value) to Deflate (wrong value) after GetCompressedStream() is called in ZipArchiveEntry.OpenEntryStream(). When OpenEntryStream() is called again, it thinks it is encrypted with PKWARE traditional encryption rather than WinZipAes, which fails. I made a change to ZipArchiveEntry.OpenEntryStream() to save and restore the compression method which resolves this issue. I can provide this as a patch. This behavior has changed since 0.11, the previous version we used. OpenEntryStream() should be able to be called more than once since it returns a non-seekable stream, this allows for resetting the stream for a file entry back to the beginning of the entry.
claunia added the bug label 2026-01-29 22:07:47 +00:00
claunia commented 2026-01-29 22:07:47 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (May 19, 2017):

Please provide a pull request and maybe extent a test to test for it. Probably just an oversight.

@adamhathcock commented on GitHub (May 19, 2017): Please provide a pull request and maybe extent a test to test for it. Probably just an oversight.
claunia commented 2026-01-29 22:07:47 +00:00
Author
Owner
Copy Link

@dbaumber commented on GitHub (May 23, 2017):

I've submitted pull a request. I'll work on a test for it next. Would it be possible to get this fix into the 0.16 release? This is an important issue for us. Thanks!

@dbaumber commented on GitHub (May 23, 2017): I've submitted pull a request. I'll work on a test for it next. Would it be possible to get this fix into the 0.16 release? This is an important issue for us. Thanks!
claunia commented 2026-01-29 22:07:48 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (May 23, 2017):

I can easily put out a patch version if things are simple enough.

@adamhathcock commented on GitHub (May 23, 2017): I can easily put out a patch version if things are simple enough.
claunia commented 2026-01-29 22:07:48 +00:00
Author
Owner
Copy Link

@dbaumber commented on GitHub (May 23, 2017):

It is a 4 line change in ZipArchiveEntry.OpenEntryStream(). It has no effect on anything else. I don't quite understand why the compression method changes but preserving it over the GetCompressedStream() call fixes our issue. We don't need a special patch version if the 0.16 release is coming in the next week or so.

@dbaumber commented on GitHub (May 23, 2017): It is a 4 line change in ZipArchiveEntry.OpenEntryStream(). It has no effect on anything else. I don't quite understand why the compression method changes but preserving it over the GetCompressedStream() call fixes our issue. We don't need a special patch version if the 0.16 release is coming in the next week or so.
claunia commented 2026-01-29 22:07:48 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (May 24, 2017):

Put in 0.16.1

@adamhathcock commented on GitHub (May 24, 2017): Put in 0.16.1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#174
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?