[PR #174] [MERGED] Redo options #874

New Issue

Open

opened 2026-01-29 22:17:57 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 22:17:57 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/174
Author: @adamhathcock
Created: 9/27/2016
Status: ✅ Merged
Merged: 9/28/2016
Merged by: @adamhathcock

Base: master ← Head: redo_options

---

📝 Commits (6)

• c4fde80 Create proper options objects to remove flags from API
• 5dafcb0 Redo options classes
• 177fc2a Flags were a better idea when I was younger. It's not clear though.
• d715208 Helps if I rename everything
• 260c0ee Add SaveTo overload for zip archives
• 911e987 Merge branch 'master' into redo_options

📊 Changes

56 files changed (+686 additions, -677 deletions)

View changed files

📝 src/SharpCompress/Archives/AbstractArchive.cs (+12 -12)
📝 src/SharpCompress/Archives/AbstractWritableArchive.cs (+9 -8)
📝 src/SharpCompress/Archives/ArchiveFactory.cs (+16 -32)
📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+18 -52)
📝 src/SharpCompress/Archives/IArchiveEntryExtensions.cs (+15 -4)
📝 src/SharpCompress/Archives/IArchiveExtensions.cs (+3 -2)
📝 src/SharpCompress/Archives/IWritableArchive.cs (+2 -2)
📝 src/SharpCompress/Archives/IWritableArchiveExtensions.cs (+5 -28)
📝 src/SharpCompress/Archives/Rar/FileInfoRarArchiveVolume.cs (+9 -12)
📝 src/SharpCompress/Archives/Rar/FileInfoRarFilePart.cs (+3 -3)
📝 src/SharpCompress/Archives/Rar/RarArchive.cs (+30 -41)
📝 src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs (+6 -6)
📝 src/SharpCompress/Archives/Rar/StreamRarArchiveVolume.cs (+4 -4)
📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+18 -51)
📝 src/SharpCompress/Archives/Tar/TarArchive.cs (+29 -59)
📝 src/SharpCompress/Archives/Zip/ZipArchive.cs (+34 -70)
➖ src/SharpCompress/Common/CompressionInfo.cs (+0 -30)
📝 src/SharpCompress/Common/GZip/GZipVolume.cs (+4 -2)
📝 src/SharpCompress/Common/IEntry.Extensions.cs (+5 -4)
➖ src/SharpCompress/Common/Options.cs (+0 -23)

...and 36 more files

📄 Description

Things have gotten nasty over the years so a minor refactor of options across the board is due as I have some time during a job transition.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/174 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 9/27/2016 **Status:** ✅ Merged **Merged:** 9/28/2016 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `redo_options` --- ### 📝 Commits (6) - [`c4fde80`](https://github.com/adamhathcock/sharpcompress/commit/c4fde80c5e886256028260c80669bb319ececfee) Create proper options objects to remove flags from API - [`5dafcb0`](https://github.com/adamhathcock/sharpcompress/commit/5dafcb02d462daa8a9eb5a89be08fd38b40e1d3d) Redo options classes - [`177fc2a`](https://github.com/adamhathcock/sharpcompress/commit/177fc2a12cb84e75e7cf071eab8fc725dc7ddfc1) Flags were a better idea when I was younger. It's not clear though. - [`d715208`](https://github.com/adamhathcock/sharpcompress/commit/d71520808d7e3105e6cacd4b3a9c78856bf29255) Helps if I rename everything - [`260c0ee`](https://github.com/adamhathcock/sharpcompress/commit/260c0ee776eef2f758eece3ac49ca5abb73b5fe0) Add SaveTo overload for zip archives - [`911e987`](https://github.com/adamhathcock/sharpcompress/commit/911e9878bd902214abcc0b2ffb22b98454fc0c42) Merge branch 'master' into redo_options ### 📊 Changes **56 files changed** (+686 additions, -677 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/AbstractArchive.cs` (+12 -12) 📝 `src/SharpCompress/Archives/AbstractWritableArchive.cs` (+9 -8) 📝 `src/SharpCompress/Archives/ArchiveFactory.cs` (+16 -32) 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+18 -52) 📝 `src/SharpCompress/Archives/IArchiveEntryExtensions.cs` (+15 -4) 📝 `src/SharpCompress/Archives/IArchiveExtensions.cs` (+3 -2) 📝 `src/SharpCompress/Archives/IWritableArchive.cs` (+2 -2) 📝 `src/SharpCompress/Archives/IWritableArchiveExtensions.cs` (+5 -28) 📝 `src/SharpCompress/Archives/Rar/FileInfoRarArchiveVolume.cs` (+9 -12) 📝 `src/SharpCompress/Archives/Rar/FileInfoRarFilePart.cs` (+3 -3) 📝 `src/SharpCompress/Archives/Rar/RarArchive.cs` (+30 -41) 📝 `src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs` (+6 -6) 📝 `src/SharpCompress/Archives/Rar/StreamRarArchiveVolume.cs` (+4 -4) 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+18 -51) 📝 `src/SharpCompress/Archives/Tar/TarArchive.cs` (+29 -59) 📝 `src/SharpCompress/Archives/Zip/ZipArchive.cs` (+34 -70) ➖ `src/SharpCompress/Common/CompressionInfo.cs` (+0 -30) 📝 `src/SharpCompress/Common/GZip/GZipVolume.cs` (+4 -2) 📝 `src/SharpCompress/Common/IEntry.Extensions.cs` (+5 -4) ➖ `src/SharpCompress/Common/Options.cs` (+0 -23) _...and 36 more files_ </details> ### 📄 Description Things have gotten nasty over the years so a minor refactor of options across the board is due as I have some time during a job transition. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 22:17:57 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

copilot/add-lzwreader-support

adam/add-alternate-compressions

adam/cleanup-options

copilot/fix-openentrystreamasync-memory-issue

release

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

0.44.5

0.44.4

0.44.3

0.44.2

0.44.1

0.44.0

0.43.0

0.42.1

0.42.0

0.41.0

0.40.0

0.39.0

0.38.0

0.37.2

0.37.1

0.37.0

0.36.0

0.35.0

0.34.2

0.34.1

0.34.0

0.33.0

0.32.2

0.32.1

0.32

0.31

0.30.1

0.30

0.29

0.29.0

0.28.3

0.28.2

0.28.1

0.28

0.27.1

0.27

0.26

0.25.1

0.25

0.24

0.23

0.22

0.21.1

0.21

0.21.0

0.20.0

0.19.2

0.19.1

0.19

0.18.2

0.18.1

0.18

0.17.1

0.17.0

0.16.2

0.16.1

0.16.0

0.15.2

0.15.1

0.15.0

0.14.1

0.14.0

0.13.1

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.6

0.11.5

0.11.4

0.11.3

0.11.2

0.11.1

0.11

0.10.3

0.10.2

0.10.1.3

0.10.1.2

0.10.1.1

0.10.1

0.10

0.9

Labels

Clear labels

bug

duplicate

enhancement

feedback requested

not bug

pull-request

Mirrored from GitHub Pull Request

question

up for grabs

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#874