starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

RarRijndael throws NullReferenceException when there is no password #461

New Issue
Open
opened 2026-01-29 22:12:25 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:12:25 +00:00
Owner
Copy Link

Originally created by @IS4Code on GitHub (May 15, 2021).

Rar parsing (via RarReader, haven't tested other archive types) has a bug when the password is not set (null) and the archive is encrypted. When the header is encrypted too, it correctly throws CryptographicException, but when only the files are encrypted, MoveToNextEntry throws NullReferenceException, as it attempts to initialize the engine with a null password.

I could use a blank password, but this breaks encrypted headers, as it cannot determine the format. I would prefer a CryptographicException thrown when an encrypted file is opened without a password (but its entry should be accessible).

Ideally, there should be some sort of wrong password detection as well, but fixing the first bug is completely sufficient.

Originally created by @IS4Code on GitHub (May 15, 2021). Rar parsing (via RarReader, haven't tested other archive types) has a bug when the password is not set (null) and the archive is encrypted. When the header is encrypted too, it correctly throws `CryptographicException`, but when only the files are encrypted, `MoveToNextEntry` throws `NullReferenceException`, as it attempts to initialize the engine with a null password. I could use a blank password, but this breaks encrypted headers, as it cannot determine the format. I would prefer a `CryptographicException` thrown when an encrypted file is opened without a password (but its entry should be accessible). Ideally, there should be some sort of wrong password detection as well, but fixing the first bug is completely sufficient.
claunia commented 2026-01-29 22:12:26 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jun 4, 2021):

I'll accept a PR for this.

I think there isn't a good way (or used not to be) to detect encrypted files so an explicit exception wasn't done at the time.

@adamhathcock commented on GitHub (Jun 4, 2021): I'll accept a PR for this. I think there isn't a good way (or used not to be) to detect encrypted files so an explicit exception wasn't done at the time.
claunia commented 2026-01-29 22:12:26 +00:00
Author
Owner
Copy Link

@Nanook commented on GitHub (May 4, 2022):

I noticed this issue and found that checking IsEncrypted on the Entry was the best method. If you're not using passwords then you should not attempt to process an Entry with IsEncrypted is True.

If the archive is encrypted with encrypted filenames then catching SharpCompresses CryptographicException when no password is set indicates it's passworded. #663 aligns 7zip to this behaviour also.

I've only tested this behaviour with Archive Open(), but is should be the same for RarReader too.

@Nanook commented on GitHub (May 4, 2022): I noticed this issue and found that checking IsEncrypted on the Entry was the best method. If you're not using passwords then you should not attempt to process an Entry with IsEncrypted is True. If the archive is encrypted with encrypted filenames then catching SharpCompresses CryptographicException when no password is set indicates it's passworded. #663 aligns 7zip to this behaviour also. I've only tested this behaviour with Archive Open(), but is should be the same for RarReader too.
claunia commented 2026-01-29 22:12:27 +00:00
Author
Owner
Copy Link

@IS4Code commented on GitHub (May 4, 2022):

I noticed this issue and found that checking IsEncrypted on the Entry was the best method. If you're not using passwords then you should not attempt to process an Entry with IsEncrypted is True.

If the archive is encrypted with encrypted filenames then catching SharpCompresses CryptographicException when no password is set indicates it's passworded. #663 aligns 7zip to this behaviour also.

I've only tested this behaviour with Archive Open(), but is should be the same for RarReader too.

Yes, it makes sense not to open an encrypted entry, but as I said, MoveToNextEntry itself throws the exception. Iterating the entries and retrieving their metadata should be still valid even without a password.

@IS4Code commented on GitHub (May 4, 2022): > I noticed this issue and found that checking IsEncrypted on the Entry was the best method. If you're not using passwords then you should not attempt to process an Entry with IsEncrypted is True. > > If the archive is encrypted with encrypted filenames then catching SharpCompresses CryptographicException when no password is set indicates it's passworded. #663 aligns 7zip to this behaviour also. > > I've only tested this behaviour with Archive Open(), but is should be the same for RarReader too. Yes, it makes sense not to open an encrypted entry, but as I said, `MoveToNextEntry` itself throws the exception. Iterating the entries and retrieving their metadata should be still valid even without a password.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#461
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?