starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

CompressionInfo on AddFile does not work #82

New Issue
Closed
opened 2026-01-29 22:06:16 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:06:16 +00:00
Owner
Copy Link

Originally created by @kenkendk on GitHub (Jan 25, 2016).

When calling WriteToStream and supplying a CompressionInfo instance, it appears to be ignored.
Instead, the implementation reads the CompressionInfo instance passed to the constructor for the ZipWriter. By hacking it with reflection, I can change the CompressionLevel field on the original instance, and that allows me to change the compression level on a per-stream basis.

Originally created by @kenkendk on GitHub (Jan 25, 2016). When calling `WriteToStream` and supplying a `CompressionInfo` instance, it appears to be ignored. Instead, the implementation reads the `CompressionInfo` instance passed to the constructor for the `ZipWriter`. By hacking it with reflection, I can change the `CompressionLevel` field on the original instance, and that allows me to change the compression level on a per-stream basis.
claunia commented 2026-01-29 22:06:17 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Feb 3, 2016):

Any chance for a PR? I'll queue this up to look at.

@adamhathcock commented on GitHub (Feb 3, 2016): Any chance for a PR? I'll queue this up to look at.
claunia commented 2026-01-29 22:06:17 +00:00
Author
Owner
Copy Link

@kenkendk commented on GitHub (Feb 4, 2016):

Yes, there is now a PR.

There should also be a unittest for this, but I have not made that.

@kenkendk commented on GitHub (Feb 4, 2016): Yes, there is now a PR. There should also be a unittest for this, but I have not made that.
claunia commented 2026-01-29 22:06:17 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Feb 4, 2016):

Thanks! I'll test it later.

@adamhathcock commented on GitHub (Feb 4, 2016): Thanks! I'll test it later.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#82
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?