starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #82] [MERGED] Issue 79 #824

New Issue
Open
opened 2026-01-29 22:17:44 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:17:44 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/82
Author: @haykpetros
Created: 8/4/2015
Status: ✅ Merged
Merged: 8/4/2015
Merged by: @adamhathcock

Base: master ← Head: issue_79

📝 Commits (2)

  • 2e928e8 Removed unused method.
  • 35a8b44 I feel there is no need to use unsafe version, so conditional compilation has been removed and only safe version kept.

📊 Changes

2 files changed (+0 additions, -48 deletions)

View changed files

📝 SharpCompress/Compressor/LZMA/CRC.cs (+0 -28)
📝 SharpCompress/Utility.cs (+0 -20)

📄 Description

  1. Removed one unused method.
  2. Removed conditional compilation so now only managed version of WriteLittleEndian method will be used both for regular as well as Portable versions of code.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/82 **Author:** [@haykpetros](https://github.com/haykpetros) **Created:** 8/4/2015 **Status:** ✅ Merged **Merged:** 8/4/2015 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `issue_79` --- ### 📝 Commits (2) - [`2e928e8`](https://github.com/adamhathcock/sharpcompress/commit/2e928e86fd10627c9139c074a37e55de986e75e6) Removed unused method. - [`35a8b44`](https://github.com/adamhathcock/sharpcompress/commit/35a8b444b8bbd21aaee69387c65ef873617d5a8e) I feel there is no need to use unsafe version, so conditional compilation has been removed and only safe version kept. ### 📊 Changes **2 files changed** (+0 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `SharpCompress/Compressor/LZMA/CRC.cs` (+0 -28) 📝 `SharpCompress/Utility.cs` (+0 -20) </details> ### 📄 Description 1. Removed one unused method. 2. Removed conditional compilation so now only managed version of WriteLittleEndian method will be used both for regular as well as Portable versions of code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:17:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#824
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?