mirror of
https://github.com/microsoft/terminal.git
synced 2026-04-05 21:45:25 +00:00
spell; prefer AppDisplayName; use C++20 designated init
This commit is contained in:
4
.github/actions/spelling/expect/expect.txt
vendored
4
.github/actions/spelling/expect/expect.txt
vendored
@@ -1135,9 +1135,7 @@ NOSIZE
|
||||
NOSNAPSHOT
|
||||
NOTHOUSANDS
|
||||
NOTICKS
|
||||
notifArgs
|
||||
notifBody
|
||||
notifTitle
|
||||
notif
|
||||
NOTIMEOUTIFNOTHUNG
|
||||
NOTIMPL
|
||||
NOTOPMOST
|
||||
|
||||
@@ -739,10 +739,6 @@
|
||||
<value>Windows</value>
|
||||
<comment>This is displayed as a label for the context menu item that holds the submenu of available windows.</comment>
|
||||
</data>
|
||||
<data name="NotificationTitle" xml:space="preserve">
|
||||
<value>Windows Terminal</value>
|
||||
<comment>Title shown in desktop toast notifications sent by the terminal.</comment>
|
||||
</data>
|
||||
<data name="NotificationMessage_TabActivity" xml:space="preserve">
|
||||
<value>Activity in tab "{0}"</value>
|
||||
<comment>{0} is the tab title. Shown as the body of a desktop notification when tab activity is detected.</comment>
|
||||
|
||||
@@ -1230,13 +1230,14 @@ namespace winrt::TerminalApp::implementation
|
||||
{
|
||||
message = RS_fmt(L"NotificationMessage_TabActivity", std::wstring_view{ tabTitle });
|
||||
}
|
||||
notificationTitle = RS_(L"NotificationTitle");
|
||||
notificationTitle = CascadiaSettings::ApplicationDisplayName();
|
||||
}
|
||||
|
||||
implementation::DesktopNotificationArgs args;
|
||||
args.Title = notificationTitle;
|
||||
args.Message = message;
|
||||
args.TabIndex = tabIndex;
|
||||
const implementation::DesktopNotificationArgs args{
|
||||
.Title = notificationTitle,
|
||||
.Message = message,
|
||||
.TabIndex = tabIndex,
|
||||
};
|
||||
|
||||
implementation::DesktopNotification::SendNotification(args, [weakThis{ get_weak() }](uint32_t idx) {
|
||||
if (const auto page{ weakThis.get() })
|
||||
|
||||
Reference in New Issue
Block a user