starred/terminal-microsoft
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 17:46:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix resw comment + directly call VM fns

Browse Source
This commit is contained in:
Carlos Zamora
2026-06-22 13:35:17 -07:00
parent 9d38c1c398
commit 9009dfab9b
4 changed files with 3 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/cascadia/TerminalSettingsEditor/Profiles.cpp
View File

@@ -39,16 +39,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
TelemetryPrivacyDataTag(PDT_ProductAndServiceUsage));
}
void Profiles::Defaults_Click(const IInspectable& /*sender*/, const RoutedEventArgs& /*args*/)
{
_ViewModel.RequestOpenDefaults();
}
void Profiles::ColorSchemes_Click(const IInspectable& /*sender*/, const RoutedEventArgs& /*args*/)
{
_ViewModel.RequestOpenColorSchemes();
}
// The primary "+" half of the SplitButton — adds either a new empty
// profile or a duplicate of the currently selected source profile,
// depending on what the user picked from the flyout.

2
src/cascadia/TerminalSettingsEditor/Profiles.h
View File

@@ -59,8 +59,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
void OnNavigatedTo(const winrt::Windows::UI::Xaml::Navigation::NavigationEventArgs& e);
void Defaults_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);
void ColorSchemes_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);
void AddProfile_Click(const Microsoft::UI::Xaml::Controls::SplitButton& sender, const Microsoft::UI::Xaml::Controls::SplitButtonClickEventArgs& args);
void AddProfileFlyout_Opening(const Windows::Foundation::IInspectable& sender, const Windows::Foundation::IInspectable& args);
void Profile_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);

4
src/cascadia/TerminalSettingsEditor/Profiles.xaml
View File

@@ -28,7 +28,7 @@
<!-- Defaults navigator -->
<local:SettingsCard x:Name="DefaultsNavigator"
x:Uid="Profiles_DefaultsNavigator"
Click="Defaults_Click"
Click="{x:Bind ViewModel.RequestOpenDefaults}"
IsClickEnabled="True">
<local:SettingsCard.HeaderIcon>
<FontIcon Glyph="&#xECAA;" />
@@ -38,7 +38,7 @@
<!-- Color schemes navigator -->
<local:SettingsCard x:Name="ColorSchemesNavigator"
x:Uid="Profiles_ColorSchemesNavigator"
Click="ColorSchemes_Click"
Click="{x:Bind ViewModel.RequestOpenColorSchemes}"
IsClickEnabled="True">
<local:SettingsCard.HeaderIcon>
<FontIcon Glyph="&#xE790;" />

2
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
View File

@@ -1307,7 +1307,7 @@
</data>
<data name="Profiles_ColorSchemesNavigator.Header" xml:space="preserve">
<value>Color schemes</value>
<comment>Title for the "Color schemes" navigator on the Profiles landing page. Clicking this opens the same page reachable from the top-level Color schemes nav item.</comment>
<comment>Title for the "Color schemes" navigator on the Profiles landing page. Clicking this opens the the color schemes page.</comment>
</data>
<data name="Profiles_ColorSchemesNavigator.Description" xml:space="preserve">
<value>Add, edit, or remove the color schemes that your profiles can use.</value>