mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 17:46:05 +00:00

Files

Josh Soref c62bb193d3 Refresh check-spelling metadata for v0.0.26 (#20141 )

This is a refresh of spell-check-this, more or less as of
e089393b4e.

## References and Relevant Issues

A number of changes take advantage of features from
http://github.com/check-spelling/check-spelling/releases/v0.0.26

1.
[`load-config-from`](https://docs.check-spelling.dev/Configuration#load-config-from)
will allow future PRs to switch cleanly w/o the mess that this PR has --
once this merges, the `config.json` file will be used for the three
dictionary configuration elements instead of the ones in the workflow.
2. `contents: read` is no longer needed by the comment jobs as the data
is provided by the main job

Contains fixes for the following specific issues:
`without`, `with`, `with the`, `with the window`, `will be`,
`whether or not`, `where the`, `using`, `uppercase or lowercase`,
`unit testing`, `to`, `to which...`, `to which`,
`to which the view refers`, `to which the pane was moved`,
`to run a command/switch to a tab/...`,
`to retrieve the user selected command`, `time,`, `the...that the`,
`the session's initial directory`, `that`, `that will ask`, `that the`,
`that opened the first flyout`, `same as terminal,`, `results,`,
`queue,`, `please`, `pane,`, `out-of-date`, `our`, `one`, `on-screen`,
`often`, `off-screen`, `of a`, `little-endian`, `left over`,
`includes, at a minimum,`, `know of`, `its`,
`if, after the calculation,`, `if`, `if we have an`, `if dragging`,
`if commands`, `guard,`, `given process information in a list`,
`from which`, `from creating`, `for which...`, `for the axis`,
`for initializing the buffer`, `containing the cursor`, `console-wait`,
`change`, `bytes`, `be`, `baseline,`, `aumid`, `at`, `ask me *again*`,
`an`, `also need to`, `again`, `add`, `add event`, `about spelunking`,
(rewrite `Appearances::_UpdateWithNewViewModel` comment), `'a'`, and ` (`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

2026-04-24 22:50:42 +00:00

3.6 KiB

Raw Permalink Blame History

author, created on, last updated, issue id

author	created on	last updated	issue id
Dustin Howett @DHowett	2020-10-19	2020-11-18

Application State (in the Terminal Settings Model)

Abstract

Terminal is going to need a place to store application "state", including:

Dialogs the user has chosen to hide with a [ ] Do not ask again checkbox, as proposed in issue 6641
Which dynamic profiles have been generated, as a way to resolve user dissatisfaction around profiles "coming back"
On-screen position of the window, active session state, layout, etc. for eventual restoration

This specification provides for a place to store these things.

Inspiration

Many other applications store cross-session state somewhere.

Solution Design

It is the author's opinion that the above-mentioned settings are inappropriate for storage in the user's settings.json; they do not need to be propagated immediately to other instances of Windows Terminal, they are not intended to be edited, and storing them outside of settings.json defers the risk inherent in patching the user's settings file.

Therefore, this document proposes that a separate application state archive (state.json) be stored next to settings.json.

It would be accessed by way of an API hosted in the Microsoft.Terminal.Settings namespace.

namespace Microsoft.Terminal.Settings {
    [default_interface]
    runtimeclass ApplicationState {
        // GetForCurrentApplication will return an object deserialized from state.json.
        static ApplicationState GetForCurrentApplication();

        void Clear();

        IVector<guid> GeneratedProfiles;
        Boolean ShowCloseOnExitWarning;
        // ... further settings ...
    }
}

📝 The sole motivation for exposing this from Microsoft.Terminal.Settings is to concentrate JSON de-/serialization in one place.

Of note: there is no explicit Save or Commit mechanism. Changes to the application state are committed durably a short duration after they're made.

UI/UX Design

This has no direct impact on the UI/UX; however, we may want to add a button to general settings page titled "reset all dialogs" or "ask me again about those things that, some time ago, I told you to not ask me about".

We do not intend this file to be edited by hand, so it does not have to be user-friendly or serialized with indentation.

Capabilities

Accessibility

It is not expected that this proposal will impact accessibility.

Security

It is not expected that this proposal will impact security, as it uses our existing JSON parser in a new place.

Reliability

[comment]: # Will the proposed change improve reliability? If not, why make the change?

The comment in this section heavily suggests that we should only make changes that improve reliability, not ones that maintain it.

Compatibility

Some users who were expecting profiles to keep coming back after they delete them will need to adjust their behavior.

Performance, Power, and Efficiency

Potential Issues

Another file on disk is another file users might edit. We'll need to throw out the entire application state payload if it's been damaged, instead of trying to salvage it, so that we more often "do the right thing."

Future considerations

This will allow us to implement a number of the features mentioned at the head of this document.

3.6 KiB Raw Permalink Blame History