starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Make all the ICoreSettings / IControlSettings properties getters-only #10064

New Issue
Closed
opened 2026-01-31 02:11:33 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 02:11:33 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 7, 2020).

Originally assigned to: @zadjii-msft on GitHub.

We've discussed this for a while now, but it's possible now this the other work Carlos is doing with settings.

I've got a WIP branch here: dev/migrie/f/settings-getters-only, with only a few errors.

I think for each of these, the TermControl is going to need to cache a local copy of the value, to represent it's actual runtime value, rather than use the IControlSettings as a buffer.

I'm filing this so someone else can pick that up where I left off.

Originally created by @zadjii-msft on GitHub (Aug 7, 2020). Originally assigned to: @zadjii-msft on GitHub. We've discussed this for a while now, but it's possible now this the other work Carlos is doing with settings. I've got a WIP branch here: [`dev/migrie/f/settings-getters-only`](https://github.com/microsoft/terminal/tree/dev/migrie/f/settings-getters-only), with only a few errors. I think for each of these, the TermControl is going to need to cache a local copy of the value, to represent it's actual runtime value, rather than use the `IControlSettings` as a buffer. I'm filing this so someone else can pick that up where I left off.
claunia commented 2026-01-31 02:11:35 +00:00
Author
Owner
Copy Link

@MichelleTanPY commented on GitHub (Aug 26, 2020):

Hi, I thought of picking this up, and made the changes according to the WIP dev branch there. But I got a lot of errors from multiple files complaining that the argument takes 1 parameters. Any pointers or examples ?
Thanks

@MichelleTanPY commented on GitHub (Aug 26, 2020): Hi, I thought of picking this up, and made the changes according to the WIP dev branch there. But I got a lot of errors from multiple files complaining that the argument takes 1 parameters. Any pointers or examples ? Thanks
claunia commented 2026-01-31 02:11:35 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 26, 2020):

@MichelleTanPY That's basically the whole task here actually. Currently, the TermControl stashes a bunch of run time changes to the settings in it's IControlSettings object. In that WIP branch, I made all the properties getters-only, but I haven't yet changed TermControl to do the right thing here. For any of the properties where there's a compile error, you'll need to change TermControl to have some member variable that it uses to store the runtime value instead.

@zadjii-msft commented on GitHub (Aug 26, 2020): @MichelleTanPY That's basically the whole task here actually. _Currently_, the `TermControl` stashes a bunch of run time changes to the settings in it's `IControlSettings` object. In that WIP branch, I made all the properties getters-only, but I haven't yet changed `TermControl` to do the right thing here. For any of the properties where there's a compile error, you'll need to change TermControl to have some member variable that it uses to store the runtime value instead.
claunia commented 2026-01-31 02:11:35 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 3, 2022):

:tada:This issue was addressed in #11619, which has now been successfully released as Windows Terminal Preview v1.13.10336.0.🎉

Handy links:

@ghost commented on GitHub (Feb 3, 2022): :tada:This issue was addressed in #11619, which has now been successfully released as `Windows Terminal Preview v1.13.10336.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.10336.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-Settings Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#10064
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?