starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Ignore case when sorting command palette #11619

New Issue
Closed
opened 2026-01-31 02:52:41 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 02:52:41 +00:00
Owner
Copy Link

Originally created by @Don-Vito on GitHub (Nov 28, 2020).

Originally assigned to: @Don-Vito on GitHub.

Description of the new feature/enhancement

I took me a while to understand why custom commands I add appear at the bottom.
The reason is that when sorting commands in command palette we do it not lexicographically and as a result consider a case.

IMHO the case should not matter in the palette (or at least case-insensitive sorting should be optionally available).

Proposed technical implementation details (optional)

Upon comparing the filtered commands, try to set both command names to lower case and then compare lexicographically.

Originally created by @Don-Vito on GitHub (Nov 28, 2020). Originally assigned to: @Don-Vito on GitHub. # Description of the new feature/enhancement I took me a while to understand why custom commands I add appear at the bottom. The reason is that when sorting commands in command palette we do it not lexicographically and as a result consider a case. IMHO the case should not matter in the palette (or at least case-insensitive sorting should be optionally available). # Proposed technical implementation details (optional) Upon comparing the filtered commands, try to set both command names to lower case and then compare lexicographically.
claunia commented 2026-01-31 02:52:43 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 29, 2020):

@DHowett - actually I am not sure what to do 🤔

As @j4james mentioned correctly here, case is just a subset of a larger problem and will not solve accented chars, etc.

And the larger problem is described here: https://github.com/microsoft/terminal/issues/6953 - we need to use correct locale for comparison.

When I last talked to @zadjii-msft we decided that probably we should not invest in it, since in any case we want to implement https://github.com/microsoft/terminal/issues/7039 - that says not to localize the palette at all.

So now I am on the crossroads of:
1. Do nothing (hate this one)
2. Work on https://github.com/microsoft/terminal/issues/7039 (though I am not sure how to advance there - are the US_English resources packed by default in addition to other languages?)
3. Work on https://github.com/microsoft/terminal/issues/6953 - try to read the user locale and use it
4. Simply compare the strings in lowercase (will probably help only for ascii characters)

WDYT?

@Don-Vito commented on GitHub (Nov 29, 2020): ~~@DHowett - actually I am not sure what to do 🤔~~ ~~As @j4james mentioned correctly [here](https://github.com/microsoft/terminal/pull/8432#issuecomment-735304273), case is just a subset of a larger problem and will not solve accented chars, etc.~~ ~~And the larger problem is described here: https://github.com/microsoft/terminal/issues/6953 - we need to use correct locale for comparison.~~ ~~When I last talked to @zadjii-msft we decided that probably we should not invest in it, since in any case we want to implement https://github.com/microsoft/terminal/issues/7039 - that says not to localize the palette at all.~~ ~~So now I am on the crossroads of:~~ ~~1. Do nothing (hate this one)~~ ~~2. Work on https://github.com/microsoft/terminal/issues/7039 (though I am not sure how to advance there - are the US_English resources packed by default in addition to other languages?)~~ ~~3. Work on https://github.com/microsoft/terminal/issues/6953 - try to read the user locale and use it~~ ~~4. Simply compare the strings in lowercase (will probably help only for ascii characters)~~ ~~WDYT?~~
claunia commented 2026-01-31 02:52:43 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Nov 29, 2020):

Wow. I had no idea this issue was so complicated. But my understanding from reading #7039, is that VS is not just leaving the palette in English - it's listing both the native language as well as English, and allowing the search to match both of them. In that case, it still makes sense to sort with the user's native locale I would think.

If the plan is to not show the native language at all, then I guess a hardcoded US-EN locale may be best (assuming that is always available). But worst case I'd think the user's native locale would probably still be reasonable for sorting, even on English text - at least it can't be worse than ASCII ordering and seems neater than lowercasing everything (which can produce inconsistent results).

@j4james commented on GitHub (Nov 29, 2020): Wow. I had no idea this issue was so complicated. But my understanding from reading #7039, is that VS is not just leaving the palette in English - it's listing both the native language as well as English, and allowing the search to match both of them. In that case, it still makes sense to sort with the user's native locale I would think. If the plan is to not show the native language at all, then I guess a hardcoded US-EN locale may be best (assuming that is always available). But worst case I'd think the user's native locale would probably still be reasonable for sorting, even on English text - at least it can't be worse than ASCII ordering and seems neater than lowercasing everything (which can produce inconsistent results).
claunia commented 2026-01-31 02:52:44 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 29, 2020):

For the record, this seems fine to me, we'll loop back around on the "always display the EN-US command name" thing later, let's just start with this since it's a good low-hanging fix

@zadjii-msft commented on GitHub (Nov 29, 2020): For the record, this seems fine to me, we'll loop back around on the "always display the EN-US command name" thing later, let's just start with this since it's a good low-hanging fix
claunia commented 2026-01-31 02:52:44 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8432, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8432, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11619
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?