[PR #12255] [MERGED] Fix Opacity in Windows 10, again #28922

Open
opened 2026-01-31 09:31:39 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12255
Author: @zadjii-msft
Created: 1/25/2022
Status: Merged
Merged: 1/26/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/11743-win10-opacity-is-hard-02


📝 Commits (2)

  • 4779fdc Fix Opacity in Windows 10, again
  • 9c77b1c A comment update for clarity

📊 Changes

2 files changed (+23 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.idl (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+22 -1)

📄 Description

More fallout from the settings refactor. Probably because testing on a Windows
10 device is hard, because you actually need a physical machine to get acrylic
to behave correctly.

Basically, the code is simpler now, but we missed the windows 10 only edge case
where acrylic can get turned on, but we forget to enable the acrylic brush, so
it just stays off.

Refer to #11619 where this regressed, and #11643, #12229, because this is just a
hard problem apparently

  • Closes #11743. Technically OP is complaining about behavior that's
    by-design, but it made me realize this regressed in 1.12.
  • No tests on this part of the TermControl unfortunately.
  • Hauled out my old Win10 laptop to verify that opacity works right:
    • A fresh profile isn't created with any opacity
    • Mouse wheeling turns on acrylic
    • Using opacity only in the settings still stealthily enables acrylic

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12255 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/25/2022 **Status:** ✅ Merged **Merged:** 1/26/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11743-win10-opacity-is-hard-02` --- ### 📝 Commits (2) - [`4779fdc`](https://github.com/microsoft/terminal/commit/4779fdc562496552f75982093c904bafd3ae512b) Fix Opacity in Windows 10, again - [`9c77b1c`](https://github.com/microsoft/terminal/commit/9c77b1cf7bc8cf8143d230f17bd4609f950c656c) A comment update for clarity ### 📊 Changes **2 files changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+22 -1) </details> ### 📄 Description More fallout from the settings refactor. Probably because testing on a Windows 10 device is hard, because you actually need a physical machine to get acrylic to behave correctly. Basically, the code is simpler now, but we missed the windows 10 only edge case where acrylic can get turned on, but we forget to enable the acrylic brush, so it just stays off. Refer to #11619 where this regressed, and #11643, #12229, because this is just a hard problem apparently * [x] Closes #11743. Technically OP is complaining about behavior that's by-design, but it made me realize this regressed in 1.12. * [ ] No tests on this part of the `TermControl` unfortunately. * [x] Hauled out my old Win10 laptop to verify that opacity works right: - [x] A fresh profile isn't created with any opacity - [x] Mouse wheeling turns on acrylic - [x] Using `opacity` only in the settings still stealthily enables acrylic --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:39 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28922