[PR #12145] [MERGED] Use ControlProperties macros everywhere #28865

Open
opened 2026-01-31 09:31:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12145
Author: @zadjii-msft
Created: 1/12/2022
Status: Merged
Merged: 1/12/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/fix-mocks-like-i-meant-to


📝 Commits (3)

📊 Changes

5 files changed (+57 additions, -215 deletions)

View changed files

📝 scratch/ScratchIslandApp/SampleApp/MyPage.cpp (+1 -1)
📝 scratch/ScratchIslandApp/SampleApp/MySettings.h (+12 -67)
📝 src/cascadia/UnitTests_Control/MockControlSettings.h (+20 -79)
📝 src/cascadia/UnitTests_TerminalCore/MockTermSettings.h (+21 -65)
📝 src/cascadia/inc/ControlProperties.h (+3 -3)

📄 Description

When I added these macros in #11619, the real purpose was to make sure we don't forget to add new settings to these test mocks as well. However, I totally forgot to convert those. I guess that happens with a 1300 line diff ¯\_(ツ)_/¯

  • Is a codehealth thing
  • I work here
  • tests still pass

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12145 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/12/2022 **Status:** ✅ Merged **Merged:** 1/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/fix-mocks-like-i-meant-to` --- ### 📝 Commits (3) - [`696bfa5`](https://github.com/microsoft/terminal/commit/696bfa51dba9427afb553e6f810043004b037011) the core one - [`2db36a9`](https://github.com/microsoft/terminal/commit/2db36a97d4505f04df316666ad8b97b0c4e14188) the control mock too - [`f1f916d`](https://github.com/microsoft/terminal/commit/f1f916dc600241140fec2c7989ff5fdadbcb2746) fix the scratch sln too ### 📊 Changes **5 files changed** (+57 additions, -215 deletions) <details> <summary>View changed files</summary> 📝 `scratch/ScratchIslandApp/SampleApp/MyPage.cpp` (+1 -1) 📝 `scratch/ScratchIslandApp/SampleApp/MySettings.h` (+12 -67) 📝 `src/cascadia/UnitTests_Control/MockControlSettings.h` (+20 -79) 📝 `src/cascadia/UnitTests_TerminalCore/MockTermSettings.h` (+21 -65) 📝 `src/cascadia/inc/ControlProperties.h` (+3 -3) </details> ### 📄 Description When I added these macros in #11619, the real purpose was to make sure we don't forget to add new settings to these test mocks as well. However, I totally forgot to convert those. I guess that happens with a 1300 line diff ¯\\\_(ツ)_/¯ * [x] Is a codehealth thing * [x] I work here * [x] tests still pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28865