starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Duplicate code in TermControl.cpp #15657

New Issue
Closed
opened 2026-01-31 04:44:46 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 04:44:46 +00:00
Owner
Copy Link

Originally created by @serd2011 on GitHub (Oct 22, 2021).

Originally assigned to: @zadjii-msft on GitHub.

While reading code in TermControl.cpp i stumble upon two lines of code that are absolutely the same and are called one after another.
670ae2bd1c/src/cascadia/TerminalControl/TermControl.cpp (L333-L334)
670ae2bd1c/src/cascadia/TerminalControl/TermControl.cpp (L380-L381)

They are both called from TermControl::UpdateSettings()
_UpdateSettingsFromUIThread -> _ApplyUISettings and _UpdateAppearanceFromUIThread

Not sure if this is because of the situations in which this functions might be called separately but this just looks weird

Originally created by @serd2011 on GitHub (Oct 22, 2021). Originally assigned to: @zadjii-msft on GitHub. While reading code in [TermControl.cpp](https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalControl/TermControl.cpp) i stumble upon two lines of code that are absolutely the same and are called one after another. https://github.com/microsoft/terminal/blob/670ae2bd1c78fd2cc5b8e88f426eacab71fe1bfb/src/cascadia/TerminalControl/TermControl.cpp#L333-L334 https://github.com/microsoft/terminal/blob/670ae2bd1c78fd2cc5b8e88f426eacab71fe1bfb/src/cascadia/TerminalControl/TermControl.cpp#L380-L381 They are both called from ```TermControl::UpdateSettings()``` ```_UpdateSettingsFromUIThread``` -> ```_ApplyUISettings``` and ```_UpdateAppearanceFromUIThread``` Not sure if this is because of the situations in which this functions might be called separately but this just looks weird
claunia commented 2026-01-31 04:44:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 23, 2021):

I think I already got rid of this code in the branch I'm working on this 😋 But I'll leave it open to make sure.

@zadjii-msft commented on GitHub (Oct 23, 2021): I think I already got rid of this code in the branch I'm working on this 😋 But I'll leave it open to make sure.
claunia commented 2026-01-31 04:44:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 26, 2021):

Just double checked this, yep, I've got this fixed. I'll include this one in the PR.

@zadjii-msft commented on GitHub (Oct 26, 2021): Just double checked this, yep, I've got this fixed. I'll include this one in the PR.
claunia commented 2026-01-31 04:44:47 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 3, 2022):

:tada:This issue was addressed in #11619, which has now been successfully released as Windows Terminal Preview v1.13.10336.0.🎉

Handy links:

@ghost commented on GitHub (Feb 3, 2022): :tada:This issue was addressed in #11619, which has now been successfully released as `Windows Terminal Preview v1.13.10336.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.10336.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15657
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?