[PR #12095] [MERGED] Fix scheme previewing on Appearances page of SUI #28838

Open
opened 2026-01-31 09:31:06 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12095
Author: @zadjii-msft
Created: 1/5/2022
Status: Merged
Merged: 1/7/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/11893-scheme-preview-in-sui


📝 Commits (1)

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Profiles.cpp (+3 -3)

📄 Description

This PR makes sure profile appearances in SUI set both focused and unfocused members of the control. I totally forgot about the fact that the control is unfocused in the SUI. Verified manually, I didn't think it deserved a gif.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12095 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/5/2022 **Status:** ✅ Merged **Merged:** 1/7/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11893-scheme-preview-in-sui` --- ### 📝 Commits (1) - [`e96813b`](https://github.com/microsoft/terminal/commit/e96813b9c9956d2d7cdd85dae454bdb7d502d1ca) well that was dumb ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Profiles.cpp` (+3 -3) </details> ### 📄 Description This PR makes sure profile appearances in SUI set both focused and unfocused members of the control. I totally forgot about the fact that the control is _unfocused_ in the SUI. Verified manually, I didn't think it deserved a gif. * regressed in #11619 * Closes #11893 * I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:06 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28838